Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry cluster creation if socket_vmnet permissions are denied #16651

Closed
wants to merge 1 commit into from
Closed

Don't retry cluster creation if socket_vmnet permissions are denied #16651

wants to merge 1 commit into from

Conversation

termdew
Copy link

@termdew termdew commented Jun 8, 2023

The creation of a QEMU-based cluster should be terminated and not be retried if the permissions for socket_vmnet are not correct.

Fixes #16647.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: termdew
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @termdew. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 8, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

pkg/drivers/qemu/qemu.go Outdated Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Jun 9, 2023

@termdew can u plz post before/after this PR ?

@termdew
Copy link
Author

termdew commented Jun 10, 2023

@termdew can u plz post before/after this PR ?

What do you mean exactly? The behavior of minikube before and after the PR?

@termdew
Copy link
Author

termdew commented Jun 23, 2023

@medyagh
Hi 🙂 I just wanted to ask again what do you mean with your comment? 🙂

@spowelljr
Copy link
Member

@medyagh Hi 🙂 I just wanted to ask again what do you mean with your comment? 🙂

He's looking for running minikube start --driver qemu on the master branch and showing the output, then the same command but with this PR. Similar to #16839

@termdew
Copy link
Author

termdew commented Aug 11, 2023

@spowelljr @medyagh

Before PR:
Bildschirmfoto 2023-08-11 um 21 10 44

After PR:
Bildschirmfoto 2023-08-11 um 21 12 01

@termdew
Copy link
Author

termdew commented Sep 2, 2023

@spowelljr @medyagh Do you need further information? 🙂

@termdew termdew closed this by deleting the head repository Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qemu: avoid retrying when there is permission errror
5 participants