-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't retry cluster creation if socket_vmnet permissions are denied #16651
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: termdew The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @termdew. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
@termdew can u plz post before/after this PR ? |
What do you mean exactly? The behavior of minikube before and after the PR? |
@medyagh |
@spowelljr @medyagh Do you need further information? 🙂 |
The creation of a QEMU-based cluster should be terminated and not be retried if the permissions for socket_vmnet are not correct.
Fixes #16647.