Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cephfs kernel module to minikube iso #1669

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

kokhang
Copy link
Contributor

@kokhang kokhang commented Jun 30, 2017

Fix #1668

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dlorenc
Copy link
Contributor

dlorenc commented Jun 30, 2017

@minikube-bot ok to test

@codecov-io
Copy link

Codecov Report

Merging #1669 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files          51       51           
  Lines        2670     2670           
=======================================
  Hits         1033     1033           
  Misses       1456     1456           
  Partials      181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a191e5...1e105f5. Read the comment docs.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 30, 2017

You should be able to sanity test your built iso (to make sure ceph works) at this URL: http://storage.googleapis.com/minikube-builds/1669/minikube.iso

I'm running a few tests on it now.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 30, 2017

$ cat /proc/config.gz | gunzip | grep CEPH
CONFIG_CEPH_LIB=y
# CONFIG_CEPH_LIB_PRETTYDEBUG is not set
# CONFIG_CEPH_LIB_USE_DNS_RESOLVER is not set
CONFIG_CEPH_FS=m
CONFIG_CEPH_FS_POSIX_ACL=y

@dlorenc
Copy link
Contributor

dlorenc commented Jun 30, 2017

@kokhang can you ack that the ceph stuff you need works in this ISO? I'll merge after that and then push out a new build.

@kokhang
Copy link
Contributor Author

kokhang commented Jun 30, 2017

@dlorenc It works. The module does get included.
$ find /lib/modules/$(uname -r)/kernel/fs -type f -name '*.ko' | grep -E 'ceph' /lib/modules/4.9.13/kernel/fs/ceph/ceph.ko

Also my test script worked. I was able to mount a ceph FS with this minikube ISO.
Thank you!

@dlorenc dlorenc merged commit d90a5a2 into kubernetes:master Jun 30, 2017
@kokhang kokhang deleted the cephfs branch July 13, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants