Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicbase/ISO: Update cri-dockerd from v0.3.2 to v0.3.3 #16703

Merged

Conversation

minikube-bot
Copy link
Collaborator

The cri-dockerd project released a new version

This PR was auto-generated by make update-cri-dockerd-version using update-cri-dockerd-version.yml CI Workflow.

A minikube maintainer needs to checkout this PR, run make build-and-upload-cri-dockerd-binaries, and then comment ok-to-build-iso & ok-to-build-image.

@minikube-bot minikube-bot force-pushed the auto_bump_cri_dockerd_version branch from 3c2bc8a to 417a8d6 Compare June 13, 2023 21:08
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2023
@minikube-bot minikube-bot force-pushed the auto_bump_cri_dockerd_version branch from 417a8d6 to 3e8e650 Compare June 19, 2023 10:03
@spowelljr spowelljr force-pushed the auto_bump_cri_dockerd_version branch from 3e8e650 to 06251cb Compare June 21, 2023 17:06
@spowelljr
Copy link
Member

ok-to-build-image

@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16703) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 49.9s               |
| enable ingress | 28.8s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube start: 50.1s 51.4s 52.6s 48.4s 52.1s
Times for minikube (PR 16703) start: 51.3s 50.8s 48.6s 47.5s 51.1s

Times for minikube ingress: 35.1s 27.2s 27.1s 27.2s 27.2s
Times for minikube (PR 16703) ingress: 27.7s 25.2s 28.7s 27.7s 29.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16703) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 24.1s               |
| enable ingress | 48.5s    | 48.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 16703) start: 21.6s 25.9s 22.8s 25.3s 24.9s
Times for minikube start: 24.0s 24.4s 25.0s 24.4s 21.9s

Times for minikube ingress: 47.8s 49.3s 48.3s 48.8s 48.4s
Times for minikube (PR 16703) ingress: 48.8s 48.8s 47.4s 49.4s 48.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16703) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.0s               |
| enable ingress | 31.2s    | 31.6s               |
+----------------+----------+---------------------+

Times for minikube start: 20.9s 20.8s 20.9s 23.7s 23.0s
Times for minikube (PR 16703) start: 21.1s 20.9s 21.5s 23.1s 23.3s

Times for minikube ingress: 30.3s 31.4s 31.4s 31.4s 31.4s
Times for minikube (PR 16703) ingress: 31.4s 31.4s 31.4s 32.4s 31.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestErrorSpam/setup (gopogh) 9.52 (chart)
QEMU_macOS TestJSONOutput/pause/Command (gopogh) 9.52 (chart)
QEMU_macOS TestJSONOutput/start/Command (gopogh) 9.52 (chart)
QEMU_macOS TestJSONOutput/unpause/Command (gopogh) 9.52 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: minikube-bot, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@spowelljr spowelljr merged commit b1ee261 into kubernetes:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants