Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subcommand cannot be translated #16852

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

aiyijing
Copy link
Contributor

@aiyijing aiyijing commented Jul 9, 2023

Close #16851

Before:

$ LANG=zh-CN minikube image build -h
Build a container image, using the container runtime.

Examples:
minikube image build .

Options:
    --all=false:
        Build image on all nodes.

    --build-env=[]:
        Environment variables to pass to the build. (format: key=value)

    --build-opt=[]:
        Specify arbitrary flags to pass to the build. (format: key=value)

    -f, --file='':
        Path to the Dockerfile to use (optional)

    -n, --node='':
        The node to build on. Defaults to the primary control plane.

    --push=false:
        Push the new image (requires tag)

    -t, --tag='':
        Tag to apply to the new image (optional)

Usage:
  minikube image build PATH | URL | - [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).

After:

$ LANG=zh-CN minikube image build -h
使用容器运行时构建容器映像。

Examples:
minikube image build .

Options:
    --all=false:
        在所有节点上构建映像。

    --build-env=[]:
        Environment variables to pass to the build. (format: key=value)

    --build-opt=[]:
        Specify arbitrary flags to pass to the build. (format: key=value)

    -f, --file='':
        Path to the Dockerfile to use (optional)

    -n, --node='':
        要构建的节点,默认为主控制平面

    --push=false:
        Push the new image (requires tag)

    -t, --tag='':
        Tag to apply to the new image (optional)

Usage:
  minikube image build PATH | URL | - [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).

Signed-off-by: aiyijing <aiyijing@live.com>
@k8s-ci-robot k8s-ci-robot requested review from prezha and spowelljr July 9, 2023 14:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @aiyijing. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

spowelljr

This comment was marked as outdated.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up the naming

cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
jayscodeasy and others added 2 commits July 13, 2023 06:36
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
@aiyijing aiyijing requested a review from spowelljr July 12, 2023 23:00
cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
@spowelljr spowelljr merged commit 085433c into kubernetes:master Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aiyijing, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommand cannot be translated
5 participants