-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the stable path for brew installed qemu firmware in machine config #16853
Use the stable path for brew installed qemu firmware in machine config #16853
Conversation
Previously, machine config had hard coded the homebrew cellar path with the patch version of qemu available at the time of machine creation, and was prone to breaking anytime qemu was updated and the machine is restarted. This change replaces the firmware path to use the prefix as reported by 'brew --prefix qemu' (e.g. /opt/homebrew/opt/qemu on M1) which is a symlink the the latest installed version of qemu (e.g. /opt/homebrew/Cellar/qemu/<x.y.z>)
Welcome @tmoschou! |
Hi @tmoschou. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Just to clarify as I had to validate myself:
|
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube ingress: 28.3s 29.2s 27.8s 27.8s 25.9s Times for minikube start: 53.1s 51.1s 50.6s 50.7s 49.6s docker driver with docker runtime
Times for minikube (PR 16853) start: 22.2s 24.6s 25.2s 25.9s 22.8s Times for minikube ingress: 48.4s 50.4s 48.4s 49.4s 49.9s docker driver with containerd runtime
Times for minikube start: 23.5s 21.1s 22.1s 22.9s 23.7s Times for minikube ingress: 47.4s 31.4s 31.4s 31.4s 19.4s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmoschou very good PR ! thank you for this PR, I look forward to see more contributions from you
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr, tmoschou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously, machine config had hard coded the homebrew cellar path with the patch version of qemu available at the time of machine creation, and was prone to breaking anytime qemu was updated and the machine is restarted.
For example
This change replaces the firmware path on machine creation to use the prefix as reported by
brew --prefix qemu
(e.g./opt/homebrew/opt/qemu
on M1) which is a symlink the the latest installed version of qemu (e.g./opt/homebrew/Cellar/qemu/<x.y.z>
).This will not attempt to repair the path of machine with existing config. Two workarounds are to either
minikube delete
and recreate machine.