Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni: Fix regression in auto selection #16912

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

spowelljr
Copy link
Member

Fixes #16911

Before:

$ minikube start --driver docker --container-runtime=docker --version=v1.26.6
...
I0718 14:49:13.457621   40145 cni.go:149] "docker" driver + "docker" runtime found, recommending kindnet
...

After:

$ minikube start --driver docker --container-runtime=docker --version=v1.26.6
...
I0718 14:55:13.614039   41957 cni.go:158] "docker" driver + "docker" container runtime found on kubernetes v1.24+, recommending bridge
...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 18, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16912) |
+----------------+----------+---------------------+
| minikube start | 51.1s    | 51.4s               |
| enable ingress | 27.1s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.7s 28.7s 27.2s 26.7s 27.2s
Times for minikube (PR 16912) ingress: 27.2s 27.2s 27.2s 27.7s 28.2s

Times for minikube start: 52.0s 52.3s 50.7s 47.2s 53.3s
Times for minikube (PR 16912) start: 51.6s 50.4s 51.7s 52.0s 51.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16912) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.7s               |
| enable ingress | 48.8s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 22.7s 24.9s 21.9s 25.2s
Times for minikube (PR 16912) start: 24.3s 21.6s 22.0s 21.6s 24.2s

Times for minikube ingress: 49.3s 48.8s 48.4s 48.3s 49.3s
Times for minikube (PR 16912) ingress: 20.8s 21.8s 20.4s 20.8s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16912) |
+----------------+----------+---------------------+
| minikube start | 20.9s    | 21.7s               |
| enable ingress | 34.6s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 16912) start: 23.1s 22.8s 20.5s 21.5s 20.4s
Times for minikube start: 20.5s 20.2s 20.2s 23.3s 20.5s

Times for minikube ingress: 31.3s 31.3s 31.4s 31.4s 47.4s
Times for minikube (PR 16912) ingress: 34.3s 20.3s 31.4s 31.4s 31.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/parallel/Ingress (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestPause/serial/SecondStartNoReconfiguration (gopogh) 16.15 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh) 45.45 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 55aa6b2 into kubernetes:master Jul 19, 2023
20 checks passed
@spowelljr spowelljr deleted the fixCNIRegression branch July 19, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in CNI auto select in v1.31.0
4 participants