Verify containerd storage separately from docker #16972
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| armUpload = flag.Bool("arm-upload", false, "Upload the arm64 preload tarballs to GCS") | ||
| armPreloadsDir = flag.String("arm-preloads-dir", "artifacts", "Directory containing the arm64 preload tarballs") | ||
| dockerStorageDriver = "overlay2" | ||
| containerdSnapshotter = "overlayfs" |
There was a problem hiding this comment.
@afbjorklund do u mind adding details, since when containerd snapshotter is different from docker storage driver?
and how is our current containerd NOT broken with this preload ?
do we need to Bump a new preload version for force all new ones be with this snapshotter?
There was a problem hiding this comment.
There are no changes, i.e. it is the same format. Just that we should not be checking docker, when looking for containerd config. In the future, one of them might change format - without affecting the other one.
Therefore, we should name the preload (without changing the contents):
preloaded-images-k8s-v18-v1.28.0-rc.0-containerd-overlayfs-amd64.tar.lz4
There was a problem hiding this comment.
var storageDriver string
if containerRuntime == "cri-o" {
storageDriver = "overlay"
} else {
storageDriver = "overlay2"
}missing a code path for containerd
Previously docker and containerd were both using docker checks, for preload