Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added msize and 9p-version flags to mount. Also changed their defaul… #1705

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

aaron-prindle
Copy link
Contributor

…ts to be more usable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2017
@codecov-io
Copy link

codecov-io commented Jul 17, 2017

Codecov Report

Merging #1705 into master will increase coverage by <.01%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
+ Coverage   35.95%   35.96%   +<.01%     
==========================================
  Files          51       51              
  Lines        3332     3337       +5     
==========================================
+ Hits         1198     1200       +2     
- Misses       1954     1957       +3     
  Partials      180      180
Impacted Files Coverage Δ
pkg/minikube/cluster/commands.go 54.96% <0%> (-1.5%) ⬇️
pkg/minikube/cluster/cluster.go 41.12% <0%> (ø) ⬆️
cmd/minikube/cmd/mount.go 7.29% <66.66%> (+0.97%) ⬆️
pkg/util/kubeconfig/config.go 46.15% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32dc5d0...6f42d58. Read the comment docs.

@aaron-prindle
Copy link
Contributor Author

Fixes #1562 #1515

@dlorenc
Copy link
Contributor

dlorenc commented Jul 18, 2017

@minikube-bot test this please

2 similar comments
@dlorenc
Copy link
Contributor

dlorenc commented Jul 18, 2017

@minikube-bot test this please

@dlorenc
Copy link
Contributor

dlorenc commented Jul 18, 2017

@minikube-bot test this please

@dlorenc
Copy link
Contributor

dlorenc commented Jul 18, 2017

Tests are actually running now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants