Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading the wrong kubeadm images for k8s versions after minikube release #17373

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

spowelljr
Copy link
Member

Before:

$ time minikube start --kubernetes-version v1.25.14 --preload=false
πŸ˜„  minikube v1.31.2 on Darwin 13.6 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh
πŸ“Œ  Using Docker Desktop driver with root privileges
πŸ‘  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
πŸ”₯  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.25.14 on Docker 24.0.6 ...
    β–ͺ Generating certificates and keys ...
    β–ͺ Booting up control plane ...
    β–ͺ Configuring RBAC rules ...
πŸ”—  Configuring bridge CNI (Container Networking Interface) ...
πŸ”Ž  Verifying Kubernetes components...
    β–ͺ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass

❗  /opt/homebrew/bin/kubectl is version 1.28.2, which may have incompatibilities with Kubernetes 1.25.14.
    β–ͺ Want kubectl v1.25.14? Try 'minikube kubectl -- get pods -A'
πŸ„  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

real	0m50.138s
user	0m5.385s
sys	0m7.114s

After:

$ time minikube start --kubernetes-version v1.25.14 --preload=false
πŸ˜„  minikube v1.31.2 on Darwin 13.6 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh
πŸ“Œ  Using Docker Desktop driver with root privileges
πŸ‘  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
πŸ”₯  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.25.14 on Docker 24.0.6 ...
    β–ͺ Generating certificates and keys ...
    β–ͺ Booting up control plane ...
    β–ͺ Configuring RBAC rules ...
πŸ”—  Configuring bridge CNI (Container Networking Interface) ...
πŸ”Ž  Verifying Kubernetes components...
    β–ͺ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass

❗  /opt/homebrew/bin/kubectl is version 1.28.2, which may have incompatibilities with Kubernetes 1.25.14.
    β–ͺ Want kubectl v1.25.14? Try 'minikube kubectl -- get pods -A'
πŸ„  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

real	0m39.053s
user	0m5.624s
sys	0m7.008s

11 second speedup by not downloading the wrong images the first time. This speed increase is dependent on internet speed, slower internet speeds with see a bigger improvement.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2023
@spowelljr spowelljr changed the title Improve getting the correct kubeadm image version for Kubernetes version post release Fix downloading the wrong kubeadm images Oct 6, 2023
@medyagh
Copy link
Member

medyagh commented Oct 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 6, 2023
@medyagh medyagh changed the title Fix downloading the wrong kubeadm images Fix downloading the wrong kubeadm images for k8s versions after minikube release Oct 9, 2023
@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17373) |
+----------------+----------+---------------------+
| minikube start | 53.7s    | 52.8s               |
| enable ingress | 28.3s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 55.7s 54.4s 52.7s 51.9s 53.9s
Times for minikube (PR 17373) start: 52.3s 53.2s 54.4s 52.7s 51.4s

Times for minikube ingress: 27.9s 28.3s 27.9s 29.8s 27.9s
Times for minikube (PR 17373) ingress: 28.3s 29.2s 28.8s 29.8s 28.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17373) |
+----------------+----------+---------------------+
| minikube start | 24.8s    | 23.8s               |
| enable ingress | 20.8s    | 20.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 17373) start: 25.2s 23.2s 23.1s 23.6s 23.7s
Times for minikube start: 25.6s 25.2s 24.4s 21.7s 27.1s

Times for minikube ingress: 20.4s 21.9s 20.4s 20.9s 20.5s
Times for minikube (PR 17373) ingress: 20.9s 20.4s 20.4s 21.9s 19.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17373) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 24.1s               |
| enable ingress | 31.9s    | 34.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.9s 18.9s 47.4s 30.9s 31.4s
Times for minikube (PR 17373) ingress: 31.0s 31.9s 47.4s 31.4s 31.0s

Times for minikube (PR 17373) start: 25.1s 21.7s 24.8s 24.4s 24.4s
Times for minikube start: 22.4s 24.7s 23.3s 21.4s 24.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 2.27 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 9b237ee into kubernetes:master Oct 26, 2023
35 of 49 checks passed
@spowelljr spowelljr deleted the kubeadm branch October 26, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants