Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 20s timeout to driver status check #17553

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ComradeProgrammer
Copy link
Member

FIX #17479
Add timeout check at 2 places:

  • When driver.Status() is called, which calls the StatusChekcer of that driver via registry.Status()
  • When driver.Choices() is called, which calls the StatusChecker of that driver via registry.Available()

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ComradeProgrammer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Nov 5, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17553) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.3s               |
| enable ingress | 26.8s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube start: 53.1s 51.1s 49.9s 49.3s 50.9s
Times for minikube (PR 17553) start: 50.9s 50.0s 49.8s 50.8s 50.0s

Times for minikube ingress: 23.7s 27.2s 27.6s 27.6s 28.1s
Times for minikube (PR 17553) ingress: 23.7s 27.1s 26.1s 26.7s 25.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17553) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 23.9s               |
| enable ingress | 19.5s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 17.8s 20.9s 18.8s 21.3s 18.8s
Times for minikube (PR 17553) ingress: 22.8s 20.8s 20.8s 20.3s 20.3s

Times for minikube start: 21.7s 25.0s 21.6s 21.5s 24.3s
Times for minikube (PR 17553) start: 24.3s 24.1s 24.5s 24.3s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17553) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 22.3s               |
| enable ingress | 34.7s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 20.3s 21.1s 20.9s 23.3s 19.9s
Times for minikube (PR 17553) start: 20.3s 23.4s 23.1s 23.2s 21.8s

Times for minikube ingress: 31.3s 31.3s 47.3s 31.3s 32.3s
Times for minikube (PR 17553) ingress: 31.3s 32.3s 19.3s 32.4s 30.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestMissingContainerUpgrade (gopogh) 0.00 (chart)
KVM_Linux_crio TestNoKubernetes/serial/StartNoArgs (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/CertSync (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/FileSync (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/NodeLabels (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 37.50 (chart)
Hyperkit_macOS TestFunctional/parallel/SSHCmd (gopogh) 37.50 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to an example of this happening in the PR description?

@medyagh medyagh merged commit d531e2e into kubernetes:master Nov 29, 2023
35 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

driver status should not take long
5 participants