addons: Update Inspektor Gadget entrypoint and cleanup. #17740
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @eiffel-fl. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
… v0.23.1 This commit bumps Inspektor Gadget addon from v0.22.0 to v0.23.1. To avoid deployment failures, we also need to update the YAML. Indeed, Inspektor Gadget container entrypoint and cleanup programs were translated from bash to golang [1, 2]. Upstream YAML file used to deploy was updated to reflect this change [3]. Sadly, it was not the case for the YAML used to deploy the minikube addon which leaded to troubles [4, 5, 6]. Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com> [1]: inspektor-gadget/inspektor-gadget@b268d38 [2]: inspektor-gadget/inspektor-gadget@3dba83f [3]: inspektor-gadget/inspektor-gadget@992399f#diff-0927404b80a3c13f63de64a0c7af1833ba3dfd4b4e1dd07b09cb8216c7f033fcR46 [4]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio_arm64.html#fail_TestAddons/parallel/InspektorGadget [5]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget [6]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/KVM_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
eiffel-fl
force-pushed
the
francis/fix-ig-entrypoint
branch
from
e9a03cb to
6db73b2
Compare
|
kvm2 driver with docker runtime |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eiffel-fl, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thank you for the merge! I will close the corresponding issue! |
Hi!
Inspektor Gadget container entrypoint and cleanup programs were translated from
bash to golang [1, 2].
Upstream YAML file used to deploy was updated to reflect this change [3].
Sadly, it was not the case for the YAML used to deploy the minikube addon which
leaded to troubles [4, 5, 6].
The present commit updates the minikube addon YAML to use the correct programs
as entrypoint and cleanup.
Best regards.