Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Failed to enable container runtime: sudo systemctl restart cri-docker" #17907

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Jan 6, 2024

fixes #16799
fixes #16432
fixes #16273

as reported in the above issues, restarting cri-docker sometimes fails due to racing conditions between restarting the cri-docker socket and service, which this pr addresses

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2024
@prezha prezha force-pushed the fix-cri-docker-restart branch from 4228031 to 7ea9a0d Compare January 6, 2024 18:13
@prezha prezha mentioned this pull request Jan 6, 2024
@medyagh
Copy link
Member

medyagh commented Jan 8, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 8, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17907) |
+----------------+----------+---------------------+
| minikube start | 51.3s    | 51.7s               |
| enable ingress | 25.7s    | 25.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 17907) start: 50.7s 55.2s 48.2s 52.7s 51.4s
Times for minikube start: 53.5s 48.8s 51.7s 50.1s 52.6s

Times for minikube ingress: 26.6s 24.7s 27.1s 23.6s 26.6s
Times for minikube (PR 17907) ingress: 23.6s 23.2s 27.2s 26.7s 27.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17907) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 23.0s               |
| enable ingress | 19.8s    | 19.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.8s 24.3s 22.6s 22.8s 24.3s
Times for minikube (PR 17907) start: 24.1s 22.1s 24.6s 22.1s 22.1s

Times for minikube ingress: 20.3s 21.3s 20.9s 17.8s 18.8s
Times for minikube (PR 17907) ingress: 18.3s 20.8s 20.8s 17.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17907) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.8s               |
| enable ingress | 31.7s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 22.0s 20.6s 23.6s 21.3s
Times for minikube (PR 17907) start: 24.0s 23.9s 24.4s 20.4s 21.4s

Times for minikube ingress: 18.3s 31.3s 31.3s 30.3s 47.3s
Times for minikube (PR 17907) ingress: 31.4s 30.3s 30.3s 31.3s 46.3s

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for getting to the bottom of this @prezha!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 00de339 into kubernetes:master Jan 10, 2024
27 of 41 checks passed
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio_arm64 TestMissingContainerUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_Linux_crio TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
Docker_Linux_crio TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Docker_Linux_crio TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Hyper-V_Windows TestMinikubeProfile (gopogh) 0.00 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
KVM_Linux_crio TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
KVM_Linux_crio TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh) 0.00 (chart)
KVM_Linux_crio TestStartStop/group/newest-cni/serial/Stop (gopogh) 0.00 (chart)
KVM_Linux_crio TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
QEMU_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 0.00 (chart)
QEMU_macOS TestStoppedBinaryUpgrade/Setup (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestFunctional/serial/LogsFileCmd (gopogh) 2.13 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/NodeLabels (gopogh) 4.26 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 4.26 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ServiceCmd/Format (gopogh) 4.26 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 4.26 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 4.26 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ServiceCmd/List (gopogh) 4.26 (chart)
Docker_Linux_containerd_arm64 TestFunctional/parallel/ServiceCmd/URL (gopogh) 4.26 (chart)
Hyper-V_Windows TestCertExpiration (gopogh) 4.76 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 4.96 (chart)
Hyper-V_Windows TestStartStop/group/no-preload/serial/SecondStart (gopogh) 5.00 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd/Format (gopogh) 9.52 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 9.52 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants