-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "Failed to enable container runtime: sudo systemctl restart cri-docker" #17907
Conversation
4228031
to
7ea9a0d
Compare
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube (PR 17907) start: 50.7s 55.2s 48.2s 52.7s 51.4s Times for minikube ingress: 26.6s 24.7s 27.1s 23.6s 26.6s docker driver with docker runtime
Times for minikube start: 21.8s 24.3s 22.6s 22.8s 24.3s Times for minikube ingress: 20.3s 21.3s 20.9s 17.8s 18.8s docker driver with containerd runtime
Times for minikube start: 23.2s 22.0s 20.6s 23.6s 21.3s Times for minikube ingress: 18.3s 31.3s 31.3s 30.3s 47.3s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for getting to the bottom of this @prezha!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prezha, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
fixes #16799
fixes #16432
fixes #16273
as reported in the above issues, restarting cri-docker sometimes fails due to racing conditions between restarting the cri-docker socket and service, which this pr addresses