support image-repository contain numeric characters

[allenhaozi]

support --image-repository contain numeric characters

fix #18279

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: allenhaozi
Once this PR has been reviewed and has the lgtm label, please assign afbjorklund for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[linux-foundation-easycla]

• ✅login: allenhaozi / (ae35871)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @allenhaozi!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @allenhaozi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liangyuanpeng]

LGTM, I also need it.

Really have a PR to work for it #17496

Any PR that gets merged is fine with me :)

/cc @spowelljr @medyagh

[medyagh]

/ok-to-test

[medyagh]

thank you @allenhaozi for this PR, and thank you @liangyuanpeng for your pointing out the other PR

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18290) |
+----------------+----------+---------------------+
| minikube start | 53.7s    | 55.4s               |
| enable ingress | 25.9s    | 25.8s               |
+----------------+----------+---------------------+

Times for minikube start: 52.1s 55.7s 52.2s 54.9s 53.4s
Times for minikube (PR 18290) start: 57.9s 54.1s 57.0s 56.5s 51.7s

Times for minikube ingress: 26.7s 22.7s 27.1s 26.6s 26.7s
Times for minikube (PR 18290) ingress: 26.7s 23.6s 26.6s 26.7s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18290) |
+----------------+----------+---------------------+
| minikube start | 24.8s    | 25.2s               |
| enable ingress | 21.3s    | 20.1s               |
+----------------+----------+---------------------+

Times for minikube start: 25.3s 25.8s 25.7s 23.3s 23.8s
Times for minikube (PR 18290) start: 25.3s 23.3s 25.9s 25.6s 25.7s

Times for minikube ingress: 20.4s 20.4s 21.4s 19.8s 24.4s
Times for minikube (PR 18290) ingress: 19.4s 20.8s 20.4s 20.4s 19.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18290) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.8s               |
| enable ingress | 30.6s    | 30.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.5s 21.5s 23.7s 22.2s 25.2s
Times for minikube (PR 18290) start: 22.2s 22.5s 23.8s 21.4s 24.1s

Times for minikube ingress: 30.9s 30.9s 30.8s 29.8s 30.8s
Times for minikube (PR 18290) ingress: 30.9s 30.9s 30.8s 30.9s 30.8s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestMountStart/serial/StartWithMountSecond (gopogh)	1.25 (chart)
Docker_Linux_crio_arm64	TestMultiControlPlane/serial/RestartCluster (gopogh)	16.67 (chart)
QEMU_macOS	TestAddons/Setup (gopogh)	21.57 (chart)
QEMU_macOS	TestErrorSpam/setup (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/CpCmd (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/FileSync (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/SSHCmd (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/Version/components (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/serial/LogsCmd (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/serial/LogsFileCmd (gopogh)	21.57 (chart)
QEMU_macOS	TestFunctional/parallel/CertSync (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/DockerEnv/bash (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListShort (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/NodeLabels (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/DeployApp (gopogh)	23.53 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/Format (gopogh)	23.53 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

[allenhaozi]

duplicated #17496