Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon: add addon for volcano #18602

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Apr 8, 2024

Based on #13876
Add volcano addon, together with Invalid integration test fixed and incorrect manifest digest changed.
A auto updater is also added.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ComradeProgrammer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 8, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Apr 8, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2024
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add auto updater for this addon so when there is a new verison it should update itself

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented Apr 19, 2024

@ComradeProgrammer we could add the auto updater for the addon in a follow up PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@medyagh
Copy link
Member

medyagh commented Apr 19, 2024

it seems like the arm64 test all fail so we shoudl tell users this is NOT supported for arm64 so they dont enable it
and also same for crio
we should skip the test and say doesnt work for crio yet

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18602) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 51.2s               |
| enable ingress | 27.2s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.5s 24.5s 28.0s 28.0s 28.0s
Times for minikube (PR 18602) ingress: 25.0s 29.0s 28.5s 25.0s 27.5s

Times for minikube start: 49.7s 54.6s 50.7s 50.0s 49.7s
Times for minikube (PR 18602) start: 49.7s 50.9s 52.7s 49.8s 52.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18602) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 23.0s               |
| enable ingress | 21.7s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 20.4s 20.9s 21.4s 23.7s
Times for minikube (PR 18602) start: 20.9s 25.0s 21.4s 23.8s 24.0s

Times for minikube ingress: 21.3s 21.8s 21.8s 21.8s 21.8s
Times for minikube (PR 18602) ingress: 21.3s 21.8s 21.8s 21.2s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18602) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.1s               |
| enable ingress | 32.0s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 20.4s 21.6s 23.2s 21.3s
Times for minikube (PR 18602) start: 20.8s 23.2s 18.9s 20.8s 21.6s

Times for minikube ingress: 31.8s 31.8s 32.3s 32.3s 31.8s
Times for minikube (PR 18602) ingress: 31.8s 30.8s 32.3s 31.3s 32.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) n/a
KVM_Linux_containerd TestFunctional/parallel/ConfigCmd (gopogh) 0.00 (chart)
KVM_Linux_crio TestNetworkPlugins/group/bridge/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 1.10 (chart)
KVM_Linux TestNoKubernetes/serial/ProfileList (gopogh) 1.16 (chart)
KVM_Linux_crio TestMultiControlPlane/serial/DeleteSecondaryNode (gopogh) 2.33 (chart)
KVM_Linux_crio TestMultiControlPlane/serial/AddSecondaryNode (gopogh) 4.14 (chart)
QEMU_macOS TestImageBuild/serial/Setup (gopogh) 45.65 (chart)
QEMU_macOS TestJSONOutput/pause/Command (gopogh) 46.74 (chart)
QEMU_macOS TestJSONOutput/start/Command (gopogh) 46.74 (chart)
QEMU_macOS TestJSONOutput/unpause/Command (gopogh) 46.74 (chart)
QEMU_macOS TestMinikubeProfile (gopogh) 46.74 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 48.26 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 3e10cfc into kubernetes:master May 22, 2024
23 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants