ISO: Add 50-fs-inotify.conf to increase limits #18832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @nirs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
This avoids random failures starting kubevirt VMs like:
failed to creating a fsnotify watcher: too many open files
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
ok-to-build-iso |
|
Hi @nirs, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
k8s-ci-robot
added
size/S
|
If someone want to test this use: (I wonder by the bot adding the iso info cannot add a useful link like this) |
|
Tested starting a new cluster with the iso: |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
medyagh
approved these changes
May 8, 2024
k8s-ci-robot
added
the
approved
|
kvm2 driver with docker runtime Times for minikube start: 53.5s 52.4s 51.8s 54.0s 53.5s Times for minikube ingress: 27.1s 25.0s 28.0s 28.1s 29.1s docker driver with docker runtime Times for minikube start: 24.9s 23.2s 24.4s 24.5s 22.4s Times for minikube ingress: 21.8s 21.8s 21.3s 21.3s 21.3s docker driver with containerd runtime Times for minikube (PR 18832) start: 22.2s 20.4s 23.0s 20.6s 19.1s Times for minikube (PR 18832) ingress: 32.3s 32.3s 32.3s 21.3s 31.8s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, nirs, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 7, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 8, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 9, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 9, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 9, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 10, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 10, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 11, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 13, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 13, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 13, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 13, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 17, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 17, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 18, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to RamenDR/ramen
that referenced
this pull request
Sep 18, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
asn1809
pushed a commit
to asn1809/ramen
that referenced
this pull request
Oct 8, 2024
Currently we have:
$ sysctl fs.inotify
fs.inotify.max_queued_events = 16384
fs.inotify.max_user_instances = 128
fs.inotify.max_user_watches = 45827
And we see errors like this on managed clusters even with trivial
busybox workloads:
failed to create fsnotify watcher: too many open files
We use OpenShift worker defaults, already used for minikube[1].
[1] kubernetes/minikube#18832
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids random failures starting kubevirt VMs like:
Fixes #18831