addons: Fail when enabling KVM addons on non-KVM cluster

[spowelljr]

Related #19114

$ minikube addons enable nvidia-driver-installer
❗  nvidia-driver-installer is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
❗  nvidia-driver-installer does not currently have an associated maintainer.

❌  The nvidia-driver-installer addon is only supported with the KVM driver.

For GPU setup instructions see: https://minikube.sigs.k8s.io/docs/tutorials/nvidia/

❌  Exiting due to MK_ADDON_ENABLE: enable failed: run callbacks: running validations: [nvidia-driver-installer addon is only supported with the KVM driver]

╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                         │
│    😿  If the above advice does not help, please let us know:                                                           │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                                                         │
│                                                                                                                         │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.                                  │
│    Please also attach the following file to the GitHub issue:                                                           │
│    - /var/folders/9l/6wpxv6wd1b901m1146r579wc00rqw3/T/minikube_addons_741713b79154053af848925874c8744175803f0e_0.log    │
│                                                                                                                         │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Also made other addon validation funcs private since they're not used outside the package.

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19195) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 51.1s               |
| enable ingress | 25.4s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 50.9s 54.2s 49.9s 47.9s 50.4s
Times for minikube (PR 19195) start: 52.0s 50.8s 51.6s 50.9s 50.2s

Times for minikube (PR 19195) ingress: 27.0s 24.9s 26.5s 28.0s 24.0s
Times for minikube ingress: 23.9s 24.9s 24.0s 26.9s 27.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19195) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 22.4s               |
| enable ingress | 22.1s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 25.1s 24.1s 24.9s 21.4s 24.3s
Times for minikube (PR 19195) start: 21.5s 22.0s 20.9s 23.5s 23.8s

Times for minikube ingress: 22.3s 22.8s 23.8s 21.3s 20.3s
Times for minikube (PR 19195) ingress: 21.8s 21.3s 20.8s 25.3s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19195) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.4s               |
| enable ingress | 29.4s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 19195) start: 21.5s 19.6s 19.8s 22.7s 23.4s
Times for minikube start: 19.7s 21.6s 22.4s 19.7s 22.3s

Times for minikube ingress: 32.3s 32.3s 19.8s 31.2s 31.2s
Times for minikube (PR 19195) ingress: 31.8s 32.3s 32.3s 31.8s 31.3s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
QEMU_macOS	TestImageBuild/serial/BuildWithBuildArg (gopogh)	n/a
Docker_Linux_crio_arm64	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	0.72 (chart)
Docker_Linux_crio_arm64	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	0.72 (chart)
Docker_Linux_crio_arm64	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	0.72 (chart)
KVM_Linux_crio	TestFunctional/parallel/MySQL (gopogh)	0.74 (chart)
QEMU_macOS	TestMultiControlPlane/serial/NodeLabels (gopogh)	15.71 (chart)
QEMU_macOS	TestMultiControlPlane/serial/HAppyAfterClusterStart (gopogh)	17.14 (chart)
QEMU_macOS	TestMultiControlPlane/serial/AddWorkerNode (gopogh)	18.57 (chart)
QEMU_macOS	TestMultiControlPlane/serial/CopyFile (gopogh)	18.57 (chart)
QEMU_macOS	TestMultiControlPlane/serial/DeployApp (gopogh)	18.57 (chart)
QEMU_macOS	TestMultiControlPlane/serial/HAppyAfterSecondaryNodeRestart (gopogh)	18.57 (chart)
QEMU_macOS	TestMultiControlPlane/serial/PingHostFromPods (gopogh)	18.57 (chart)
QEMU_macOS	TestMultiControlPlane/serial/StartCluster (gopogh)	18.57 (chart)

To see the flake rates of all tests by environment, click here.

[medyagh]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment