Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons ingress-dns: Update image to support multi-arch #19198

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jul 4, 2024

ingress-dns image now supports all archs except s390x (image never finished building)

amd64:

$ arch
x86_64

$ nslookup hello-john.test $(minikube ip)
Server:		192.168.49.2
Address:	192.168.49.2#53

Non-authoritative answer:
Name:	hello-john.test
Address: 192.168.49.2
Name:	hello-john.test
Address: 192.168.49.2

arm64:

$ arch
aarch64

$ nslookup hello-john.test $(minikube ip)
Server:         192.168.49.2
Address:        192.168.49.2#53

Non-authoritative answer:
Name:   hello-john.test
Address: 192.168.49.2
Name:   hello-john.test
Address: 192.168.49.2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2024
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 4, 2024
@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19198) |
+----------------+----------+---------------------+
| minikube start | 49.5s    | 48.9s               |
| enable ingress | 24.4s    | 25.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.3s 47.3s 52.0s 50.2s 48.6s
Times for minikube (PR 19198) start: 49.3s 50.7s 47.5s 47.4s 49.5s

Times for minikube ingress: 23.9s 23.4s 23.0s 24.9s 26.9s
Times for minikube (PR 19198) ingress: 27.0s 23.9s 26.9s 22.9s 24.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19198) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.6s               |
| enable ingress | 21.6s    | 21.3s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 23.4s 20.8s 21.5s 22.1s
Times for minikube (PR 19198) start: 20.3s 24.6s 23.2s 20.5s 24.5s

Times for minikube ingress: 21.8s 22.7s 20.3s 21.3s 21.8s
Times for minikube (PR 19198) ingress: 21.2s 21.8s 21.7s 20.3s 21.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19198) |
+----------------+----------+---------------------+
| minikube start | 19.6s    | 21.3s               |
| enable ingress | 32.5s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 19.4s 20.5s 19.5s 19.8s 18.8s
Times for minikube (PR 19198) start: 19.2s 23.1s 20.3s 23.3s 20.8s

Times for minikube ingress: 31.2s 47.3s 30.7s 19.8s 33.2s
Times for minikube (PR 19198) ingress: 32.3s 31.3s 30.8s 32.3s 31.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
Hyper-V_Windows TestPause/serial/VerifyStatus (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StartAfterStop (gopogh) 19.67 (chart)
Hyper-V_Windows TestMultiControlPlane/serial/CopyFile (gopogh) 25.42 (chart)
Hyper-V_Windows TestKubernetesUpgrade (gopogh) 26.83 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Jul 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jul 8, 2024

This makes the 100% failing test pass ! good job TestAddons/parallel/Ingress

@medyagh medyagh merged commit 8484640 into kubernetes:master Jul 8, 2024
39 of 51 checks passed
@spowelljr spowelljr deleted the updateIngressDNSImage branch July 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants