Remove "docker.io/" prefixing when listing Docker images

[thomasjm]

This PR removes the use of the addDockerIO / TrimDockerIO functions when working with Docker images, in order to address #19343.

closes #19343

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thomasjm
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @thomasjm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@thomasjm thank you for this PR, do you mind sharing the output an example, before/after this PR ?

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19344) |
+----------------+----------+---------------------+
| minikube start | 52.0s    | 51.4s               |
| enable ingress | 27.8s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 53.5s 52.5s 52.4s 51.7s 50.0s
Times for minikube (PR 19344) start: 50.9s 52.3s 52.0s 50.3s 51.8s

Times for minikube ingress: 28.1s 27.0s 28.1s 28.1s 28.0s
Times for minikube (PR 19344) ingress: 25.1s 27.5s 27.5s 25.5s 28.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19344) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 24.1s               |
| enable ingress | 22.4s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 22.7s 22.0s 25.1s 21.7s
Times for minikube (PR 19344) start: 25.5s 24.8s 24.5s 21.6s 24.1s

Times for minikube ingress: 22.3s 22.9s 21.9s 22.8s 22.3s
Times for minikube (PR 19344) ingress: 20.8s 25.3s 21.3s 20.8s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19344) |
+----------------+----------+---------------------+
| minikube start | 21.0s    | 21.9s               |
| enable ingress | 48.4s    | 39.4s               |
+----------------+----------+---------------------+

Times for minikube start: 20.3s 23.9s 20.2s 19.7s 20.8s
Times for minikube (PR 19344) start: 21.9s 22.9s 20.8s 22.9s 21.1s

Times for minikube ingress: 47.3s 47.8s 48.8s 49.3s 48.8s
Times for minikube (PR 19344) ingress: 32.8s 32.3s 50.3s 48.8s 32.8s

[thomasjm]

do you mind sharing the output an example, before/after this PR ?

Before PR:

tom@desktop2 ~ » minikube image ls                                                        
...
registry.k8s.io/coredns/coredns:v1.11.1                                                                                                                                                                            
gcr.io/k8s-minikube/storage-provisioner:v5                                                                                                                                                                         
docker.io/library/busybox:1.36.1-musl

After PR:

tom@desktop2 ~ » ~/tools/minikube/out/minikube image ls                                                        
...
registry.k8s.io/coredns/coredns:v1.11.1
gcr.io/k8s-minikube/storage-provisioner:v5
busybox:1.36.1-musl

Notice how only the busybox image, which doesn't have a domain name, is affected.

I see there are some test failures, I'll look into these when I get a minute.

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Cloud_Shell (9 failed)	TestFunctional/parallel/ImageCommands/ImageLoadDaemon(gopogh)	0.00% (chart)
Docker_Cloud_Shell (9 failed)	TestFunctional/parallel/ImageCommands/ImageReloadDaemon(gopogh)	0.00% (chart)
Docker_Cloud_Shell (9 failed)	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon(gopogh)	0.00% (chart)
Docker_Cloud_Shell (9 failed)	TestFunctional/parallel/ImageCommands/ImageLoadFromFile(gopogh)	0.00% (chart)
KVM_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadDaemon(gopogh)	0.00% (chart)
KVM_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageReloadDaemon(gopogh)	0.00% (chart)
KVM_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon(gopogh)	0.00% (chart)
KVM_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadFromFile(gopogh)	0.00% (chart)
Docker_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadDaemon(gopogh)	0.00% (chart)
Docker_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageReloadDaemon(gopogh)	0.00% (chart)
Docker_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon(gopogh)	0.00% (chart)
Docker_Linux (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadFromFile(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadDaemon(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (4 failed)	TestFunctional/parallel/ImageCommands/ImageReloadDaemon(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (4 failed)	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon(gopogh)	0.00% (chart)
Docker_Linux_docker_arm64 (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadFromFile(gopogh)	0.00% (chart)

Besides the following environments also have failed tests:

• Docker_Linux_crio: 2 failed (gopogh)

• KVM_Linux_crio: 12 failed (gopogh)

• QEMU_macOS: 156 failed (gopogh)

• Docker_Linux_containerd_arm64: 1 failed (gopogh)

• Docker_Linux_crio_arm64: 2 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[medyagh]

@thomasjm do you mind taking a look at the failed tests for Docker_Linux ?

TestFunctional/parallel/ImageCommands/ImageLoadDaemon

[thomasjm]

Oh, I wasn't sure if this PR is still desired after the discussion on #19343.

I don't totally understand the full picture, but it sounds like it's believed that this PR might break things for more strict runtimes like containerd.

If we still want to move ahead with this I can look into it.