-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon headlamp: Update headlamp-k8s/headlamp image from v0.24.1 to v0.25.0 #19349
Conversation
….25.0 Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
Hi @joaquimrocha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
@@ -779,7 +779,7 @@ var Addons = map[string]*Addon{ | |||
MustBinAsset(addons.HeadlampAssets, "headlamp/headlamp-clusterrolebinding.yaml", vmpath.GuestAddonsDir, "headlamp-clusterrolebinding.yaml", "0640"), | |||
}, false, "headlamp", "3rd party (kinvolk.io)", "yolossn", "https://minikube.sigs.k8s.io/docs/handbook/addons/headlamp/", | |||
map[string]string{ | |||
"Headlamp": "headlamp-k8s/headlamp:v0.24.1@sha256:1c3f42aacd8eee1d3f1c63efb5a3b42da387ca1d87b77b0f486e8443201fcb37", | |||
"Headlamp": "headlamp-k8s/headlamp:v0.25.0@sha256:899d106eeb55b0afc4ee6e51c03bc4418de0bd0e79c39744d4d0d751aae6a971", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaquimrocha please consider making this an automation job in github action
here is a simmilar job for kong addon.
https://github.com/kubernetes/minikube/blob/master/.github/workflows/update-kong-version.yml
you would need to make a new make target "make update-headlamp", let me know if you have any questions on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @medyagh . Thanks, that sounds very cool. Our PRs are automated anyway, but I like the idea of having the action in the minikube repo instead.
If you agree, we could merge this PR so the addon is not delayed and we'll submit the new action before our next release. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good ! btw I am curious thats good where do you run the automation ? look forward to see more contributions for you :)
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube start: 50.1s 46.7s 47.9s 49.3s 47.4s Times for minikube ingress: 27.5s 23.4s 25.4s 24.0s 24.0s docker driver with docker runtime
Times for minikube start: 24.2s 20.4s 21.2s 22.2s 21.0s Times for minikube ingress: 21.3s 21.8s 21.8s 22.8s 21.3s docker driver with containerd runtime
Times for minikube start: 22.7s 20.7s 23.3s 21.1s 24.1s Times for minikube ingress: 48.3s 48.3s 47.2s 49.3s 31.8s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
Upgrade Headlamp version to 0.25.0
cc: @joaquimrocha