Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon headlamp: Update headlamp-k8s/headlamp image from v0.24.1 to v0.25.0 #19349

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

joaquimrocha
Copy link
Contributor

Upgrade Headlamp version to 0.25.0
cc: @joaquimrocha

….25.0

Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha July 29, 2024 21:26
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@@ -779,7 +779,7 @@ var Addons = map[string]*Addon{
MustBinAsset(addons.HeadlampAssets, "headlamp/headlamp-clusterrolebinding.yaml", vmpath.GuestAddonsDir, "headlamp-clusterrolebinding.yaml", "0640"),
}, false, "headlamp", "3rd party (kinvolk.io)", "yolossn", "https://minikube.sigs.k8s.io/docs/handbook/addons/headlamp/",
map[string]string{
"Headlamp": "headlamp-k8s/headlamp:v0.24.1@sha256:1c3f42aacd8eee1d3f1c63efb5a3b42da387ca1d87b77b0f486e8443201fcb37",
"Headlamp": "headlamp-k8s/headlamp:v0.25.0@sha256:899d106eeb55b0afc4ee6e51c03bc4418de0bd0e79c39744d4d0d751aae6a971",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquimrocha please consider making this an automation job in github action
here is a simmilar job for kong addon.

https://github.com/kubernetes/minikube/blob/master/.github/workflows/update-kong-version.yml

you would need to make a new make target "make update-headlamp", let me know if you have any questions on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @medyagh . Thanks, that sounds very cool. Our PRs are automated anyway, but I like the idea of having the action in the minikube repo instead.
If you agree, we could merge this PR so the addon is not delayed and we'll submit the new action before our next release. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good ! btw I am curious thats good where do you run the automation ? look forward to see more contributions for you :)

@medyagh
Copy link
Member

medyagh commented Jul 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 19349) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 48.3s    | 71.6s ⚠️             |
| enable ingress    | 24.9s    | 25.8s               |
+-------------------+----------+---------------------+

Times for minikube start: 50.1s 46.7s 47.9s 49.3s 47.4s
Times for minikube (PR 19349) start: 52.0s 48.2s 46.8s 51.4s 159.8s

Times for minikube ingress: 27.5s 23.4s 25.4s 24.0s 24.0s
Times for minikube (PR 19349) ingress: 25.0s 24.0s 27.9s 28.0s 24.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19349) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 22.8s               |
| enable ingress | 21.8s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.2s 20.4s 21.2s 22.2s 21.0s
Times for minikube (PR 19349) start: 24.7s 24.7s 21.4s 21.3s 22.1s

Times for minikube ingress: 21.3s 21.8s 21.8s 22.8s 21.3s
Times for minikube (PR 19349) ingress: 21.3s 23.3s 21.3s 21.8s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19349) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.3s               |
| enable ingress | 45.0s    | 48.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 20.7s 23.3s 21.1s 24.1s
Times for minikube (PR 19349) start: 19.7s 22.8s 22.9s 22.6s 23.4s

Times for minikube ingress: 48.3s 48.3s 47.2s 49.3s 31.8s
Times for minikube (PR 19349) ingress: 47.8s 48.3s 48.3s 48.3s 49.3s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd_arm64 (2 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 46.95% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 732b969 into kubernetes:master Aug 3, 2024
42 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants