Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow publish and download kicbase image in github release #19464

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat: allow publish and download kicbase image in github release #19464

merged 1 commit into from
Jan 6, 2025

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Aug 17, 2024 •
edited
Loading

This PR include the following things:

  1. include tarball of the kicbase image in github release
  2. allow minkube download the kicbase from github release page if there is no available image from any registry

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2024
@ComradeProgrammer ComradeProgrammer changed the title WIP: feat: allow publish and download kicbase image in github release feat: allow publish and download kicbase image in github release Aug 19, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
spowelljr
spowelljr requested changes Aug 26, 2024
View reviewed changes
pkg/minikube/download/image.go Outdated Show resolved Hide resolved
hack/jenkins/release_build_and_upload.sh Outdated Show resolved Hide resolved
pkg/minikube/download/image.go Outdated Show resolved Hide resolved
@ComradeProgrammer
Copy link
Member Author

@spowelljr @medyagh updated

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2024
medyagh
medyagh requested changes Dec 16, 2024
View reviewed changes
hack/jenkins/release_build_and_upload.sh Show resolved Hide resolved
pkg/minikube/download/image.go Outdated Show resolved Hide resolved
pkg/minikube/download/image.go Outdated Show resolved Hide resolved
@ComradeProgrammer
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2024
@ComradeProgrammer
Copy link
Member Author

minikube/go.mod

Line 3 in 0dbe96a

go 1.22.0

Does this go version make sense? Because if you run go list -m -json all , it is shown that k8s.io/apimachinery is using go version 1.23.0, so minikube's go version should not be less than 1.23.0

@ComradeProgrammer
Copy link
Member Author

/test pull-minikube-build

@medyagh
Copy link
Member

medyagh commented Jan 6, 2025

/lgtm

@medyagh medyagh merged commit 8b72464 into kubernetes:master Jan 6, 2025
15 of 20 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
omleteer pushed a commit to omleteer/minikube that referenced this pull request Jan 8, 2025
@ComradeProgrammer
feat: allow publish and download kicbase image in github release (kub…
187b70f 
…ernetes#19464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr requested changes

@medyagh medyagh Awaiting requested review from medyagh

Assignees

@medyagh medyagh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ComradeProgrammer @k8s-triage-robot @medyagh @k8s-ci-robot @spowelljr