Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons registry: Update kube-registry-proxy from 0.0.6 to 0.0.7 #19711

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

spowelljr
Copy link
Member

Updating the kube-registry-proxy from 0.0.6 to 0.0.7

To see changes to the Dockerfile see: spowelljr/kube-registry-proxy@a153665

Updated the base image from nginx:1.25.4 to nginx:1.27.1-alpine

This resolves several CVEs

0.0.6:

65 vulnerabilities found in 28 packages
  UNSPECIFIED  5   
  LOW          42  
  MEDIUM       7   
  HIGH         6   
  CRITICAL     5 

0.0.7:

1 vulnerability found in 1 package
  LOW       0  
  MEDIUM    1  
  HIGH      0  
  CRITICAL  0  

This also resulted in a 71.5% reduction in image size

0.0.6: 192.02 MB
0.0.7: 54.66 MB

Confirmed the new image works:

$ kubectl run --rm registry-test --restart=Never --image=gcr.io/k8s-minikube/busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local"
Connecting to registry.kube-system.svc.cluster.local (10.96.254.17:80)
  HTTP/1.1 200 OK
  Cache-Control: no-cache
  Date: Thu, 26 Sep 2024 23:54:00 GMT
  Content-Length: 0
  Connection: close
  
remote file exists
pod "registry-test" deleted

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from prezha September 26, 2024 23:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 26, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19711) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 47.9s               |
| enable ingress | 15.0s    | 15.0s               |
+----------------+----------+---------------------+

Times for minikube start: 46.0s 50.5s 46.6s 50.7s 48.7s
Times for minikube (PR 19711) start: 47.0s 47.8s 49.2s 48.7s 47.2s

Times for minikube ingress: 15.1s 15.0s 15.0s 14.5s 15.5s
Times for minikube (PR 19711) ingress: 15.5s 15.0s 14.5s 15.0s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19711) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 22.2s               |
| enable ingress | 12.3s    | 12.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 24.3s 23.7s 21.5s 25.2s
Times for minikube (PR 19711) start: 20.2s 21.7s 23.7s 21.2s 24.2s

Times for minikube ingress: 12.8s 13.3s 12.8s 11.3s 11.3s
Times for minikube (PR 19711) ingress: 13.9s 12.8s 13.3s 10.8s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19711) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 20.6s               |
| enable ingress | 30.4s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 23.1s 19.8s 20.5s 19.5s
Times for minikube (PR 19711) start: 19.5s 19.5s 22.5s 19.8s 21.8s

Times for minikube ingress: 38.8s 29.0s 22.8s 22.8s 38.8s
Times for minikube (PR 19711) ingress: 28.3s 22.8s 22.8s 22.8s 38.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio_arm64 (4 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 5.17% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Sep 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
@medyagh medyagh merged commit 79ba886 into kubernetes:master Sep 27, 2024
33 of 49 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the updateKubeRegistryProxy branch September 27, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants