Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pollute minikube profile list with errors if exitcode is absent #19728

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Sep 28, 2024

before

minikube profile list

E0928 22:06:31.537339 1021169 status.go:304] exit code not found: strconv.Atoi: parsing "": invalid syntax
E0928 22:06:31.537365 1021169 status.go:304] exit code not found: strconv.Atoi: parsing "": invalid syntax
E0928 22:06:31.537379 1021169 status.go:304] exit code not found: strconv.Atoi: parsing "": invalid syntax
|---------|-----------|------------|----------------|------|---------|--------|-------|----------------|--------------------|
| Profile | VM Driver |  Runtime   |       IP       | Port | Version | Status | Nodes | Active Profile | Active Kubecontext |
|---------|-----------|------------|----------------|------|---------|--------|-------|----------------|--------------------|
| falco   | kvm2      | containerd | 192.168.39.134 | 8443 | v1.31.0 | OK     |     1 |                |                    |
|---------|-----------|------------|----------------|------|---------|--------|-------|----------------|--------------------|

after

minikube profile list

|---------|-----------|------------|----------------|------|---------|--------|-------|----------------|--------------------|
| Profile | VM Driver |  Runtime   |       IP       | Port | Version | Status | Nodes | Active Profile | Active Kubecontext |
|---------|-----------|------------|----------------|------|---------|--------|-------|----------------|--------------------|
| falco   | kvm2      | containerd | 192.168.39.134 | 8443 | v1.31.0 | OK     |     1 |                |                    |
|---------|-----------|------------|----------------|------|---------|--------|-------|----------------|--------------------|

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2024
@prezha prezha self-assigned this Sep 28, 2024
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@spowelljr spowelljr merged commit 725afe0 into kubernetes:master Sep 30, 2024
27 of 29 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants