Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change MINIKUBE_HOME logic" #20045

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Dec 4, 2024

This reverts commit 6f03675 from "Update MINIKUBE_HOME usage" (pr #18648)

fixes: #19769
replaces: #19771

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2024
@medyagh
Copy link
Member

medyagh commented Dec 4, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 4, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20045) |
+----------------+----------+---------------------+
| minikube start | 47.9s    | 48.4s               |
| enable ingress | 15.7s    | 15.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.3s 47.5s 47.2s 49.5s 45.8s
Times for minikube (PR 20045) start: 48.6s 51.0s 45.9s 48.0s 48.7s

Times for minikube ingress: 15.0s 15.0s 18.5s 15.0s 15.0s
Times for minikube (PR 20045) ingress: 14.5s 15.0s 15.0s 15.5s 15.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20045) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.6s               |
| enable ingress | 13.0s    | 12.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 20045) start: 20.7s 25.3s 21.2s 24.4s 21.5s
Times for minikube start: 23.5s 23.8s 21.0s 24.4s 24.2s

Times for minikube ingress: 12.3s 13.3s 13.3s 13.3s 12.8s
Times for minikube (PR 20045) ingress: 12.3s 12.3s 12.8s 12.3s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20045) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 20.7s               |
| enable ingress | 35.7s    | 37.6s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 22.5s 23.0s 22.4s 22.8s
Times for minikube (PR 20045) start: 19.9s 20.9s 22.1s 19.8s 20.9s

Times for minikube ingress: 39.3s 38.8s 38.8s 38.8s 22.8s
Times for minikube (PR 20045) ingress: 38.8s 38.8s 38.8s 38.8s 32.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd_arm64 (1 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 47.06% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 8d3ab40 into kubernetes:master Dec 11, 2024
39 of 49 checks passed
@medyagh
Copy link
Member

medyagh commented Dec 11, 2024

thank you @prezha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants