Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make by skipping kvm2-arm64 till 19959 is resolved #20062

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Dec 8, 2024

related: #19959 / #19985

$ arch

arm64

$ make clean && make && make docker-machine-driver-kvm2 && make test

before

rm -rf ~/go/src/github.com/prezha/minikube/out
rm -f pkg/minikube/assets/assets.go
rm -f pkg/minikube/translate/translations.go
rm -rf ./vendor
rm -rf /tmp/tmp.*.minikube_*
go build  -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.34.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.34.0-1730913550-19917 -X k8s.io/minikube/pkg/version.gitCommitID="3b895bd10da35649b9ed192054ac5e418b8c96fc" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -o out/minikube k8s.io/minikube/cmd/minikube
echo "not used till https://github.com/kubernetes/minikube/issues/19959"
not used till https://github.com/kubernetes/minikube/issues/19959
cp out/docker-machine-driver-kvm2-arm64 out/docker-machine-driver-kvm2
cp: out/docker-machine-driver-kvm2-arm64: No such file or directory
make: *** [out/docker-machine-driver-kvm2] Error 1

after

rm -rf ~/go/src/github.com/prezha/minikube/out
rm -f pkg/minikube/assets/assets.go
rm -f pkg/minikube/translate/translations.go
rm -rf ./vendor
rm -rf /tmp/tmp.*.minikube_*
go build  -tags "" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.34.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.34.0-1730913550-19917 -X k8s.io/minikube/pkg/version.gitCommitID="3b895bd10da35649b9ed192054ac5e418b8c96fc-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -o out/minikube k8s.io/minikube/cmd/minikube
skipping kvm2-arm64 till https://github.com/kubernetes/minikube/issues/19959 is fixed
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.34.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.34.0-1730913550-19917 -X k8s.io/minikube/pkg/version.gitCommitID="3b895bd10da35649b9ed192054ac5e418b8c96fc-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.62.2'
golangci/golangci-lint info found version: 1.62.2 for v1.62.2/darwin/arm64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	2.919s	coverage: 20.8% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	1.243s	coverage: 24.7% of statements
ok  	k8s.io/minikube/pkg/addons	4.032s	coverage: 26.7% of statements
ok  	k8s.io/minikube/pkg/drivers	2.973s	coverage: 51.1% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	2.759s	coverage: 3.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	1.382s	coverage: 12.8% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	1.007s	coverage: 83.9% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	4.312s	coverage: 29.0% of statements
ok  	k8s.io/minikube/pkg/minikube/audit	2.572s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	6.238s	coverage: 42.1% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	5.122s	coverage: 64.1% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	5.078s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	4.210s	coverage: 73.8% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	3.030s	coverage: 6.7% of statements
ok  	k8s.io/minikube/pkg/minikube/cni	4.398s	coverage: 8.7% of statements
ok  	k8s.io/minikube/pkg/minikube/command	3.264s	coverage: 11.7% of statements
ok  	k8s.io/minikube/pkg/minikube/config	3.535s	coverage: 66.9% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	5.173s	coverage: 29.2% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	4.324s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/download	6.075s	coverage: 25.6% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	5.293s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/driver/auxdriver	4.985s	coverage: 19.0% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	4.412s	coverage: 56.9% of statements
ok  	k8s.io/minikube/pkg/minikube/image	4.549s	coverage: 5.1% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	4.242s	coverage: 78.3% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	4.226s	coverage: 48.1% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	3.727s	coverage: 5.2% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	3.175s	coverage: 20.2% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	3.897s	coverage: 6.4% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	2.441s	coverage: 79.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	2.738s	coverage: 66.5% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	3.011s	coverage: 55.4% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	7.936s	coverage: 20.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	3.829s	coverage: 74.0% of statements
ok  	k8s.io/minikube/pkg/minikube/reason	3.930s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	4.144s	coverage: 78.8% of statements
ok  	k8s.io/minikube/pkg/minikube/registry/drvs/docker	3.775s	coverage: 46.5% of statements
ok  	k8s.io/minikube/pkg/minikube/registry/drvs/hyperkit	3.760s	coverage: 41.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	7.722s	coverage: 76.6% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	2.241s	coverage: 94.4% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	3.453s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/style	3.502s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	3.952s	coverage: 5.9% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	4.057s	coverage: 27.6% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	4.300s	coverage: 57.7% of statements
ok  	k8s.io/minikube/pkg/network	1.584s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/util	2.216s	coverage: 79.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	1.991s	coverage: 10.0% of statements
ok  	k8s.io/minikube/pkg/util/retry	2.842s	coverage: 0.0% of statements
ok

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2024
@medyagh
Copy link
Member

medyagh commented Dec 9, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 9, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20062) |
+----------------+----------+---------------------+
| minikube start | 49.7s    | 50.1s               |
| enable ingress | 16.6s    | 17.1s               |
+----------------+----------+---------------------+

Times for minikube start: 50.2s 52.6s 47.7s 50.0s 47.8s
Times for minikube (PR 20062) start: 50.4s 49.5s 50.6s 49.9s 49.9s

Times for minikube ingress: 18.5s 15.0s 15.0s 19.0s 15.5s
Times for minikube (PR 20062) ingress: 18.4s 18.5s 16.0s 14.9s 18.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20062) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 21.9s               |
| enable ingress | 12.5s    | 12.9s               |
+----------------+----------+---------------------+

Times for minikube start: 19.9s 22.6s 21.5s 20.2s 23.0s
Times for minikube (PR 20062) start: 20.6s 24.1s 23.7s 20.8s 20.4s

Times for minikube ingress: 12.3s 12.3s 12.3s 13.3s 12.3s
Times for minikube (PR 20062) ingress: 12.2s 13.3s 12.8s 12.7s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20062) |
+----------------+----------+---------------------+
| minikube start | 20.5s    | 21.2s               |
| enable ingress | 34.5s    | 35.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 20062) start: 20.2s 20.5s 23.1s 22.7s 19.4s
Times for minikube start: 22.7s 18.9s 22.7s 18.5s 19.7s

Times for minikube ingress: 32.2s 38.7s 38.7s 40.0s 22.8s
Times for minikube (PR 20062) ingress: 40.2s 28.4s 38.7s 38.8s 30.2s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio (3 failed) TestFunctional/parallel/MySQL(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (1 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 47.06% (chart)
KVM_Linux_containerd (1 failed) TestAddons/parallel/Registry(gopogh) 0.00% (chart)
Docker_Linux_containerd (1 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit bccf50e into kubernetes:master Dec 10, 2024
36 of 49 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants