release: fix missing kicbase asset in release #20291
Conversation
k8s-ci-robot
added
cncf-cla: yes
medyagh
changed the title
| # upload to google bucket | ||
| gsutil -m cp out/* "gs://$BUCKET/releases/$TAGNAME/" | ||
|
|
||
| # Update "latest" release for non-beta/non-alpha builds |
There was a problem hiding this comment.
@ComradeProgrammer is this releated to this PR or is this something generally fixing ? what is exactly doing?
| @@ -136,5 +127,19 @@ do | |||
| docker rmi -f ${IMAGE_NAME} | |||
| done | |||
|
|
|||
|
|
|||
| # upload to google bucket | |||
| gsutil -m cp out/* "gs://$BUCKET/releases/$TAGNAME/" | |||
There was a problem hiding this comment.
there might be things in out folder that we dont want ? maybe like Linters binaries or somethign like that ? and why this is added to this PR? before this PR we didnt have artifacts in the GCS bucket?
There was a problem hiding this comment.
nevermind we are just moving this code
k8s-ci-robot
added
the
approved
medyagh
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ComradeProgrammer, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: fix missing kicbase in release