Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RBAC by default with kube-dns addon #2637

Closed

Conversation

jstangroome
Copy link
Contributor

A step toward #1722

Kubernetes already pre-defines a ClusterRoleBinding system:kube-dns which gives the kube-dns ServiceAccount the required rules to operate in a cluster with RBAC enabled, i.e.:

$ kubectl get clusterrole -n kube-system system:kube-dns -o yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  annotations:
    rbac.authorization.kubernetes.io/autoupdate: "true"
  labels:
    kubernetes.io/bootstrapping: rbac-defaults
  name: system:kube-dns
rules:
- apiGroups:
  - ""
  resources:
  - endpoints
  - services
  verbs:
  - list
  - watch

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jstangroome
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

Assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jstangroome
Copy link
Contributor Author

/assign @dlorenc

@dlorenc
Copy link
Contributor

dlorenc commented Mar 26, 2018

@minikube-bot ok to test

@Jokero
Copy link
Contributor

Jokero commented Apr 3, 2018

@jstangroome Builds failed?)

@jstangroome
Copy link
Contributor Author

jstangroome commented Apr 15, 2018

I've built minikube locally on a Ubuntu 18.04 machine with Golang 1.10 and run minikube start --vm-driver=none as per one of the failing test runs on this PR. The kube-dns Pod runs successfully, as the kube-dns Service Account, without any restarts. The logs for all the containers in the kube-dns Pod all look clean.

I cannot grok the reason for failure from the logs of the test runs linked in this PR discussion. I'm happy to dig further if anyone can provide some direction.

cc @Jokero

@dlorenc
Copy link
Contributor

dlorenc commented Jun 14, 2018

I think this is obsolete with the kubeadm bootstrapper.

@dlorenc dlorenc closed this Jun 14, 2018
@jstangroome jstangroome deleted the jstangroome-kube-dns-rbac branch August 11, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants