Issue #3037 change dependency management to dep #3136
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @tstromberg cc @dlorenc |
|
@tstromberg @dlorenc looks like CI stuck, can you folks check once? |
|
/test all |
|
Is there any update on ths? let's try to get this merged/working ASAP
…On Wed, Sep 19, 2018 at 8:56 PM Praveen Kumar ***@***.***> wrote:
/test all
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3136 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAHZov8xp2mMI5u5QSS9q5iFfMYGnnIks5ucj7ygaJpZM4WtKf1>
.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
|
This is awesome! I'll look into CI... |
|
Looks like a build issue for windows: vendor/github.com/docker/docker/pkg/term/term_windows.go:35:44: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_INPUTcaused the rest of the build to fail. |
|
I just added a commit to your PR that looks like it fixes the build! |
|
@tstromberg could you take a quick look at my two PRs that got the build working? |
Gopkg.toml
Outdated
|
|
||
| [[override]] | ||
| name = "k8s.io/api" | ||
| version = "kubernetes-1.10.0" |
There was a problem hiding this comment.
I'm confused why you have this 1.10.0 as an override and 1.11.2 as the constraint? All kubernetes libraries should be pointing at the same release.
There was a problem hiding this comment.
@r2d4 so when I do dep init it always picks the 1.11.2 but after the vendor when you try to compile it always fails with an error. So that is the reason I need to override it again.
There was a problem hiding this comment.
I got it all workin with 1.11 with this TOML:
https://gist.github.com/dlorenc/07b36d97d77b5d06299307f43d2a6167
There was a problem hiding this comment.
@dlorenc why you need to override the same version if it is part of constraint like https://gist.github.com/dlorenc/07b36d97d77b5d06299307f43d2a6167#file-gopkg-toml-L72-L78 and https://gist.github.com/dlorenc/07b36d97d77b5d06299307f43d2a6167#file-gopkg-toml-L88-L94 can you try without override because that what I tried.
There was a problem hiding this comment.
Not sure what you mean, we need override for non-direct dependencies and constraint for direct ones.
There are some bugs with dep and client-go, so including everything is basically the only way I've ever seen it work.
When you bump to 1.11, you also have to add an override for:
[[override]]
name = "github.com/json-iterator/go"
version = "1.1.3-22-gf2b4162"
There was a problem hiding this comment.
@dlorenc I don't think you need to use different for direct and non-direct dependency as per doc https://golang.github.io/dep/docs/Gopkg.toml.html#override this is used only when dependencies, direct and transitive, and supersedes all other [[constraint]] declarations for that project. but I am not much expert in that side :/
There was a problem hiding this comment.
Ah, nice. I just added a commit with the jsoniter and 1.11 updates. If tests pass this should be good to go.
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| name = "k8s.io/client-go" | ||
| version = "7.0.0" |
There was a problem hiding this comment.
I would use the kubernetes-* tag for client-go as well to ensure compatibility.
praveenkumar
force-pushed
the
issue_3037
branch
from
e6fb002
to
0943e2d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: praveenkumar If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@r2d4 this is also done 👍 |
|
Here we go.... |
No description provided.