Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wait for k8s-app pods when starting with CNI #3896

Merged
merged 1 commit into from
Mar 21, 2019

Commits on Mar 18, 2019

  1. Do not wait for k8s-app pods when starting with CNI

    Previously, minikube was waiting for some pods labeled with
    "k8s-app" (e.g. "kube-dns") to be ready before indicating that
    "minikube start" was successful. However, in the case of
    "network-plugin=cni", network of such pods is managed by a CNI
    plugin which is usually started after "minikube start" has returned
    making the waiting for the pods to fail with:
    
        Error starting cluster: wait: waiting for k8s-app=kube-dns: timed out
        waiting for the condition
    
    This commit omits waiting for "k8s-app" pods if minikube is started
    with "network-plugin=cni".
    
    Reported-by: Michal Rostecki <mrostecki@opensuse.org>
    Signed-off-by: Martynas Pumputis <m@lambda.lt>
    brb committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    2d8e577 View commit details
    Browse the repository at this point in the history