Remove arch suffixes in image names #3942
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laozc If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
laozc
force-pushed
the
image-name
branch
5 times, most recently
from
dfb0422 to
20c842a
Compare
Removing arch suffixes in image names to make sure image caching work with kubeadm since 1.12.0. Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
There was a problem hiding this comment.
I think it should be possible to go over to manifests like this, instead of explicitly listing architectures.
It only says that the old image names should be kept for "backward compatibility", but not for how long.
The idea is to generate say pause image which has the manifest for all the arch(es) and say pause-amd64 which is backwards compatible for older configurations or YAML files which may have hard coded the images with suffixes.
Looks like you have already versioned it on Kubernetes 1.12+
Can verify that it works with both docker and podman, at least.
|
@minikube-bot OK to test |
tstromberg
added
the
needs-rebase
|
Thank you! |
Removing arch suffixes in image names to make sure image caching
work with kubeadm image pull.