Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable registry-proxy #4341

Merged
merged 1 commit into from
May 28, 2019
Merged

Enable registry-proxy #4341

merged 1 commit into from
May 28, 2019

Conversation

kumarom
Copy link
Contributor

@kumarom kumarom commented May 24, 2019

As per this blog and this gist, we need to deploy a registry-proxy
which will expose docker registry on the minikube host.

Once this daemon set is deployed on minikube, one can access registry on $(minikube ip):5000.
This has been tested with minikube v1.0.1 with none driver. With this, one will not have to use
kubectl port-forward. I was able to push a container image to registry using

docker push $(minikube ip):5000/test-img

And then ran it in minikube using

kubectl run -i -t test-img --image=$(minikube ip):5000/test-img --restart=Never

As per [this blog](https://blog.hasura.io/sharing-a-local-registry-for-minikube-37c7240d0615) and [this gist](https://gist.github.com/coco98/b750b3debc6d517308596c248daf3bb1), we need to deploy a registry-proxy
which will expose docker registry on the minikube host.

Once this daemon set is deployed on minikube, one can access registry on `$(minikube ip):5000`.
This has been tested with minikube v1.0.1 with none driver. With this, one will not have to use
`kubectl port-forward`. I was able to push a container image to registry using
```
docker push $(minikube ip):5000/test-img
```
And then ran it in minikube using
```
kubectl run -i -t test-img --image=$(minikube ip):5000/test-img --restart=Never
```
@k8s-ci-robot
Copy link
Contributor

Welcome @kumarom!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kumarom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kumarom
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@tstromberg
Copy link
Contributor

It looks like the CLA form is still unhappy. Does your GitHub e-mail address match the e-mail address that signed the CLA?

@kumarom
Copy link
Contributor Author

kumarom commented May 25, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 25, 2019
@kumarom
Copy link
Contributor Author

kumarom commented May 25, 2019

@tstromberg CLA form is pleased now.

@johnkattenhorn
Copy link

@kumarom - what's the best way to run this addon prior to it being added to the official release ? Can I download it and copy it somewhere so I can issue the minikube addon enable registry-proxy command ?

@tstromberg tstromberg merged commit 657221e into kubernetes:master May 28, 2019
@kumarom
Copy link
Contributor Author

kumarom commented May 29, 2019

@johnkattenhorn you could just copy this file to /etc/kubernetes/addons/registry directory on minikube VM and add-on manager will deploy this for you.

@medyagh
Copy link
Member

medyagh commented Jun 19, 2019

@kumarom what a great feature ! I am super excited to use this feature. thank you @kumarom

kumarom added a commit to kumarom/minikube that referenced this pull request Jun 20, 2019
This commit adds documentation on how to use minikube addon registry.
Related to kubernetes#4341 and kubernetes#4529
Resolves kubernetes#4531 and kubernetes#4242
kumarom added a commit to kumarom/minikube that referenced this pull request Jun 20, 2019
This commit adds documentation on how to use minikube addon registry.
Related to kubernetes#4341 and kubernetes#4529
This addresses kubernetes#4531 and kubernetes#4242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants