-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix busybox version in integration tests #4480
Conversation
Hi @u5surf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: u5surf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
travis failed the reason why it seems to be errored to install linter.
I think the linter is collapsed the dependency of the modules following this issue It is hard to think it has occurred due to change the pod image’s version |
@minikube-bot okay to test |
Thank for this PR, if this works it is actually a great help ! I restarted the build test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please change it across all other busbox pods ?
for example this one ? minikube/test/integration/testdata/busybox-mount-test.yaml
@minikube-bot okay to test |
@minikube-bot OK to test |
the testVersionUpgrade failure is related to #4418 |
Thank you so much @u5surf for the great fix, this literally saved me hours of investigating ! great contribution. |
fix #4475
To resolve domain name with nslookup , we should use busybox:1.28.4 instead of latest in the integration tests.
c.f. docker-library/busybox#48