Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busybox version in integration tests #4480

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Jun 13, 2019

fix #4475
To resolve domain name with nslookup , we should use busybox:1.28.4 instead of latest in the integration tests.
c.f. docker-library/busybox#48

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @u5surf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: u5surf
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@u5surf
Copy link
Contributor Author

u5surf commented Jun 13, 2019

travis failed the reason why it seems to be errored to install linter.

= make lint =============================================================
go: downloading github.com/golangci/golangci-lint v1.16.1-0.20190425135923-692dacb773b7
go: extracting github.com/golangci/golangci-lint v1.16.1-0.20190425135923-692dacb773b7
go: github.com/Quasilyte/go-consistent@v0.0.0-20190521200055-c6f3937de18c: parsing go.mod: unexpected module path "github.com/quasilyte/go-consistent"
go get: error loading module requirements
golangci/golangci-lint info checking GitHub for tag 'v1.16.0'
golangci/golangci-lint info found version: 1.16.0 for v1.16.0/linux/amd64
make[1]: *** [out/linters/golangci-lint] Error 1
= boilerplate 

I think the linter is collapsed the dependency of the modules following this issue
quasilyte/go-consistent#34

It is hard to think it has occurred due to change the pod image’s version

@medyagh
Copy link
Member

medyagh commented Jun 13, 2019

@minikube-bot okay to test

@medyagh
Copy link
Member

medyagh commented Jun 13, 2019

Thank for this PR, if this works it is actually a great help ! I restarted the build test...

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please change it across all other busbox pods ?

for example this one ? minikube/test/integration/testdata/busybox-mount-test.yaml

@medyagh
Copy link
Member

medyagh commented Jun 13, 2019

@minikube-bot okay to test

@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2019
@medyagh
Copy link
Member

medyagh commented Jun 14, 2019

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jun 14, 2019

the testVersionUpgrade failure is related to #4418

@medyagh
Copy link
Member

medyagh commented Jun 14, 2019

Thank you so much @u5surf for the great fix, this literally saved me hours of investigating ! great contribution.

@medyagh medyagh changed the title use busybox 1.28.4 to be worked nslookup in tests #4475 Fix busybox version in integration tests Jun 14, 2019
@medyagh medyagh merged commit 8c88558 into kubernetes:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Test Fail: nslookup kubernetes.default: NXDOMAIN
4 participants