hyperv: Run "sudo poweroff" before stopping VM

[blueelvis]

Fixes #4661 #2914

• If the driver is Hyper-V, minikube stop will first run sudo poweroff via SSH into the minikube Virtual Machine and then proceed ahead with the normal stop related procedures.
• Reduced the number of retries from 5 to 3. 5 seems to be quite high.

[k8s-ci-robot]

Hi @blueelvis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blueelvis
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

Good catch! I did not realize until now that we weren't even attempting SSH poweroff unless delete was called. Just some minor stylistic changes to request.

[tstromberg]

@minikube-bot OK to test

[medyagh]

@blueelvis the PR looks good to me, after the above comments are fixed.

[medyagh]

I mark this WIP, please ping me when updated

[tstromberg]

Tests look good. I am very eager to see this merged once review comments are addressed.

[blueelvis]

@medyagh - Done. Sorry for the delay, got caught up in office. Let me know once you are about to configure Windows tests. Would love to see how you set it up :)

@tstromberg - Glad to hear that! Just curious though that even after I have marked your comments as resolved, the robot is still saying that there are changes requested.

-Pranav

[medyagh]

@blueelvis thank you for resolving the requests, I will hook up the windows tests next week. have you tested them locally?

[blueelvis]

@medyagh - Sure. Let me know once they have been hooked up. Yes, I have tested them locally and the issues mentioned above are being fixed with this PR.