-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sch_netem kernel module for network emulation #6038
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @LaumiH! |
Hi @LaumiH. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LaumiH The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I did the CLA and hope it works now, otherwise I will look into it tomorrow. |
Signed-off-by: Laura-Marie Henning <laura-marie.henning@stud.h-da.de>
Codecov Report
@@ Coverage Diff @@
## master #6038 +/- ##
=======================================
Coverage 36.29% 36.29%
=======================================
Files 110 110
Lines 8235 8235
=======================================
Hits 2989 2989
Misses 4848 4848
Partials 398 398 |
Next try with the CLA, I have signed it just a couple of minutes ago. |
/assign @afbjorklund |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Signed-off-by: Laura-Marie Henning laura-marie.henning@stud.h-da.de
Fixes #6033.
Network emulation can e.g. be used for chaos engineering, for which minikube is a valuable environment to test new chaos experiments in.
tc qdisc add dev eth0 root netem
commands do now work inside minikube and priviledged containers.