Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if lz4 is available before trying to use it #6941

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Check if lz4 is available before trying to use it #6941

merged 1 commit into from
Mar 8, 2020

Conversation

afbjorklund
Copy link
Collaborator

Closes #6938

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 7, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh medyagh merged commit 20fe042 into kubernetes:master Mar 8, 2020
@prasadkatti
Copy link
Contributor

This is how it looks now -


😄  minikube v1.8.1 on Darwin 10.14.6
✨  Using the hyperkit driver based on existing profile
⌛  Reconfiguring existing host ...
🏃  Using the running hyperkit "minikube" VM ...
E0308 14:48:29.778734   52610 config.go:71] Failed to preload container runtime Docker: check lz4 available.: which lz4: Process exited with status 1
stdout:

stderr:
, falling back to caching images
🐳  Preparing Kubernetes v1.17.3 on Docker 19.03.6 ...
🚀  Launching Kubernetes ...
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"```

@prasadkatti
Copy link
Contributor

Wouldn't it be better if we had a single log entry saying something like -
<emoji> lz4 not installed. Could not preload container runtime Docker. Falling back to caching images

@noelleleigh noelleleigh mentioned this pull request Mar 10, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

host reuse on older ISO: Failed to preload container runtime Docker
6 participants
@afbjorklund @k8s-ci-robot @tstromberg @minikube-pr-bot @prasadkatti @medyagh