-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci machine for docker on macos #7240
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7240 +/- ##
=======================================
Coverage 37.88% 37.88%
=======================================
Files 147 147
Lines 9065 9065
=======================================
Hits 3434 3434
Misses 5206 5206
Partials 425 425 |
/ok-to-test |
Error: running mkcmp: exit status 1 |
Times for minikube: [65.565656003 65.79685391 64.961245149] Times for Minikube (PR 7240): [83.69351380799998 67.43253631600001 70.85761586800001] Averages Time Per Log
|
Times for minikube: [66.404331902 65.09086952599999 66.485362838] Times for Minikube (PR 7240): [71.799336049 71.88493954900001 70.439643144] Averages Time Per Log
|
Times for minikube: [67.656151646 66.81321036000001 67.445661271] Times for Minikube (PR 7240): [74.601816788 71.47137028700001 72.691099603] Averages Time Per Log
|
Times for minikube: [67.01222344899999 65.41998020599999 70.255176834] Times for Minikube (PR 7240): [68.014437538 70.99696362400002 68.540324046] Averages Time Per Log
|
Times for minikube: [68.071767985 64.57687968500001 64.859847204] Times for Minikube (PR 7240): [69.01536594000001 67.759602232 71.673439813] Averages Time Per Log
|
Times for minikube: [65.494496089 64.710554206 66.865664004] Times for Minikube (PR 7240): [71.470709741 70.156092163 69.16862849200001] Averages Time Per Log
|
Times for minikube: [69.81335502499999 63.492454871999996 65.155684765] Times for Minikube (PR 7240): [69.904128065 69.095540164 71.289013856] Averages Time Per Log
|
/ok-to-test |
Times for minikube: [64.377856347 64.251842912 66.45898177400001] Times for Minikube (PR 7240): [67.18599887999999 68.106887098 72.434374335] Averages Time Per Log
|
Times for minikube: [66.450912467 66.004321671 64.88725684] Times for Minikube (PR 7240): [67.237980421 65.676645471 69.14877263000001] Averages Time Per Log
|
Times for minikube: [70.129495092 66.69597175799997 74.323823423] Times for Minikube (PR 7240): [65.12903806 66.08796030300002 64.90244299700001] Averages Time Per Log
|
Times for minikube: [64.140303679 67.050565013 65.798154172] Times for Minikube (PR 7240): [65.649524847 65.89584441299999 67.28930543199999] Averages Time Per Log
|
Times for minikube: [64.74168413999999 65.817243782 66.128972804] Times for Minikube (PR 7240): [65.696214617 65.766896284 64.282270482] Averages Time Per Log
|
Update
we cant connect to our mac os machines because of this
#7251
till that ticket is solved we can not verify if this PR works.
Original PR description
our docker installation on mac os machine keeps crashing. seems like it is an issue for anyone using docker as in CI on mac os.
while trying to make docker work on travis on mac os I stumpled upon an old code of mine:
https://github.com/medyagh/travis-macos-experiment/blob/8fb615e2803a65e8bcbf4b7ec08ab237f8914adb/install_docker_hyperkit_on_travis.sh#L9
that I noticed other people have seen same issue.
More info
docker/for-mac#882 (comment)
docker/for-mac#882 (comment)
Bottom line: MAYBE be fixes our docker installation on mac os CIs