Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more debugging for certificate issues #7270

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Add more debugging for certificate issues #7270

merged 1 commit into from
Mar 28, 2020

Conversation

tstromberg
Copy link
Contributor

To help catch a race condition: #6956

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 26, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 66.297922 63.628437 63.747088]
All Times Minikube (PR 7270): [ 65.243310 65.053324 67.926455]

Average minikube: 64.557816
Average Minikube (PR 7270): 66.074363

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7270) |
+----------------------+-----------+--------------------+
| minikube v           |  0.225580 |           0.219995 |
| Creating kvm2        | 40.513980 |          40.920820 |
| Preparing Kubernetes | 21.761617 |          22.695894 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

medyagh
medyagh requested changes Mar 27, 2020
View reviewed changes
pkg/minikube/bootstrapper/certs.go
@@ -360,9 +362,16 @@ func collectCACerts() (map[string]string, error) {

// getSubjectHash calculates Certificate Subject Hash for creating certificate symlinks
func getSubjectHash(cr command.Runner, filePath string) (string, error) {
lrr, err := cr.RunCmd(exec.Command("ls", "-la", filePath))
if err != nil {
return "", err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap the error with something helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is anything extra we can add - the error already includes the command-line:

getSubjectHash: ls -la : returned exit code 1

@medyagh medyagh merged commit 356e203 into kubernetes:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@blueelvis blueelvis Awaiting requested review from blueelvis

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @minikube-pr-bot @medyagh