Extract preloaded tarball as soon as minikube volume is created (2.5s speedup) #7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH. This shaves 2-3 secnods off of `node.StartHost`
k8s-ci-robot
added
the
cncf-cla: yes
priyawadhwa
changed the title
k8s-ci-robot
added
the
size/M
priyawadhwa
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Codecov Report
@@ Coverage Diff @@
## master #7490 +/- ##
=======================================
Coverage 37.08% 37.08%
=======================================
Files 146 146
Lines 8870 8870
=======================================
Hits 3289 3289
Misses 5192 5192
Partials 389 389 |
|
Error: running mkcmp: exit status 1 |
medyagh
reviewed
Apr 7, 2020
medyagh
reviewed
Apr 7, 2020
medyagh
reviewed
Apr 7, 2020
|
All Times minikube: [ 69.636605 64.208438 65.730780] Average minikube: 66.525274 Averages Time Per Log |
medyagh
requested changes
Apr 8, 2020
added 2 commits
April 8, 2020 10:47
medyagh
approved these changes
Apr 8, 2020
|
All Times minikube: [ 64.292363 65.815860 65.294435] Average minikube: 65.134219 Averages Time Per Log |
Docker Linux
Bug:
Hyperkitold-dockernew seen issue, created an issue for it #7533 |
|
Times for minikube: [66.463368023 63.993006007 66.274228329] Times for Minikube (PR 7490): [67.73435280499999 66.85752741499999 72.69108813300001] Averages Time Per Log |
|
Times for minikube: [65.84141496699999 67.025085095 66.960568721] Times for Minikube (PR 7490): [64.850830954 65.76610339 64.125193439] Averages Time Per Log |
tstromberg
reviewed
Apr 9, 2020
| @@ -84,6 +84,19 @@ func DeleteContainer(ociBin string, name string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // PrepareContainerNode sets up the container node befpre CreateContainerNode is caleld | |||
|
Times for minikube: [66.443212253 65.529856186 67.720592094] Times for Minikube (PR 7490): [66.39431468500001 68.26888306800001 68.79210714] Averages Time Per Log |
|
Times for minikube: [66.903358719 66.50266573399999 64.877308167] Times for Minikube (PR 7490): [64.17831082100001 63.608446279 65.191711819] Averages Time Per Log |
|
Times for minikube: [65.915732116 65.501339117 65.786926499] Times for Minikube (PR 7490): [70.707164978 67.18412895399999 67.378430807] Averages Time Per Log |
|
Times for minikube: [65.746998432 65.71110493200001 71.805386753] Times for Minikube (PR 7490): [66.675511793 65.60625499999999 63.261747055] Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallel with creating the container node and setting up SSH.
This shaves 2-3 seconds off of
node.StartHost