don't allow profile name to be less than 2 characters #9367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/S
Travis tests have failedHey @medyagh, 1st Buildmake testTravisBuddy Request Identifier: 10e88000-037d-11eb-b614-dd2b96524a99 |
Codecov Report
@@ Coverage Diff @@
## master #9367 +/- ##
=======================================
Coverage 29.35% 29.35%
=======================================
Files 170 170
Lines 10362 10362
=======================================
Hits 3042 3042
Misses 6896 6896
Partials 424 424
|
priyawadhwa
approved these changes
Oct 5, 2020
cmd/minikube/cmd/start.go
Outdated
| @@ -155,7 +155,7 @@ func runStart(cmd *cobra.Command, args []string) { | |||
|
|
|||
| if !config.ProfileNameValid(ClusterFlagValue()) { | |||
| out.WarningT("Profile name '{{.name}}' is not valid", out.V{"name": ClusterFlagValue()}) | |||
| exit.Message(reason.Usage, "Only alphanumeric and dashes '-' are permitted. Minimum 1 character, starting with alphanumeric.") | |||
| exit.Message(reason.Usage, "Only alphanumeric and dashes '-' are permitted. Minimum 2 character, starting with alphanumeric.") | |||
There was a problem hiding this comment.
nit: minimum 2 character should be minimum 2 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9366