Skip to content

Commit

Permalink
CI: build container and push tar, PR: push tar
Browse files Browse the repository at this point in the history
We only need the tar to run CI tests, but we should also test building the container.

We release the container and binaries independently of this, this script is for e2e tests.
  • Loading branch information
BenTheElder committed Jul 8, 2024
1 parent 34e60f8 commit 4e0b915
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions test/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ function build-pr() {
export REGISTRY="${NPD_STAGING_REGISTRY}/pr/${PR}"
export VERSION=$(get-version)
export TAG="${VERSION}"
make push
make push-tar
write-env-file ${PR_ENV_FILENAME}
}

Expand All @@ -138,7 +138,10 @@ function build-ci() {
export REGISTRY="${NPD_STAGING_REGISTRY}/ci"
export VERSION="$(get-version)-$(date +%Y%m%d.%H%M)"
export TAG="${VERSION}"
make push
# e2e tests consume the tarball, not the container
# this is simpler to manage in the infra, and we still ensure the container
# build works locally
make push-tar build-container

# Create the env file with and without custom flags at the same time.
build-npd-custom-flags
Expand Down

0 comments on commit 4e0b915

Please sign in to comment.