-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a case is ID="centos" #379
Conversation
Hi @CuZn13. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks for adding the unit test! It's very helpful for someone like me who don't have a CentOS machine at hand to see how its /lgtm |
pkg/util/testdata/os-release-centos
Outdated
CENTOS_MANTISBT_PROJECT="CentOS-7" | ||
CENTOS_MANTISBT_PROJECT_VERSION="7" | ||
REDHAT_SUPPORT_PRODUCT="centos" | ||
REDHAT_SUPPORT_PRODUCT_VERSION="7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the formatter is complaining that this file does not have a trailing newline character.
So if you could add a newline character at the end, it would be great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Hi @CuZn13 , I think the commit "When the state changes, it may be necessary to output customized mess…" is unintentional, right? If you are working on some experiments, it's probably easier to create a new branch ( Also, I suggest you to merge the two "add an unit test for parsing the "/etc/os-release" of CentOS" commit into one. You can do that via running |
Sorry, I was careless. I'll fix it later |
add a newline character at the end
/test pull-npd-e2e-kubernetes-gce-ubuntu |
/test pull-npd-e2e-kubernetes-gce-gci-custom-flags |
/test pull-npd-e2e-kubernetes-gce-gci |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CuZn13, xueweiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
When reading "/etc/os-release" file , ID="centos", report an error “Unsupported ID in /etc/os-release:......”