Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a case is ID="centos" #379

Merged
merged 2 commits into from
Nov 14, 2019
Merged

add a case is ID="centos" #379

merged 2 commits into from
Nov 14, 2019

Conversation

CuZn13
Copy link
Contributor

@CuZn13 CuZn13 commented Oct 28, 2019

When reading "/etc/os-release" file , ID="centos", report an error “Unsupported ID in /etc/os-release:......”

@k8s-ci-robot
Copy link
Contributor

Hi @CuZn13. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2019
@xueweiz
Copy link
Contributor

xueweiz commented Oct 28, 2019

Hi @CuZn13 ,

Could you also add an unit test for parsing the "/etc/os-release" of CentOS?
You can see an example here.

Thanks!

@xueweiz
Copy link
Contributor

xueweiz commented Oct 28, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2019
@xueweiz
Copy link
Contributor

xueweiz commented Oct 29, 2019

Thanks for adding the unit test! It's very helpful for someone like me who don't have a CentOS machine at hand to see how its /etc/os-release looks like :)

/lgtm
/cc @wangzhen127
/cc @Random-Liu

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the formatter is complaining that this file does not have a trailing newline character.
So if you could add a newline character at the end, it would be great :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@xueweiz xueweiz removed their assignment Oct 29, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@CuZn13 CuZn13 requested a review from xueweiz October 29, 2019 09:32
@xueweiz
Copy link
Contributor

xueweiz commented Oct 31, 2019

Hi @CuZn13 ,

I think the commit "When the state changes, it may be necessary to output customized mess…" is unintentional, right?

If you are working on some experiments, it's probably easier to create a new branch (git checkout -b exp), and try things out there. Your current branch (which is master) is tied to this PR. It's best to keep it clean :)

Also, I suggest you to merge the two "add an unit test for parsing the "/etc/os-release" of CentOS" commit into one. You can do that via running git rebase -i HEAD^^^^, then edit the history there.

@CuZn13
Copy link
Contributor Author

CuZn13 commented Nov 1, 2019

Sorry, I was careless. I'll fix it later

@CuZn13
Copy link
Contributor Author

CuZn13 commented Nov 1, 2019

/test pull-npd-e2e-kubernetes-gce-ubuntu

@CuZn13
Copy link
Contributor Author

CuZn13 commented Nov 1, 2019

/test pull-npd-e2e-kubernetes-gce-gci-custom-flags

@CuZn13
Copy link
Contributor Author

CuZn13 commented Nov 1, 2019

/test pull-npd-e2e-kubernetes-gce-gci

@xueweiz
Copy link
Contributor

xueweiz commented Nov 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CuZn13, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@xueweiz
Copy link
Contributor

xueweiz commented Nov 13, 2019

/retest

1 similar comment
@CuZn13
Copy link
Contributor Author

CuZn13 commented Nov 14, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3ace8c2 into kubernetes:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants