Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove aufs hung check #596

Merged
merged 1 commit into from
Aug 12, 2021
Merged

remove aufs hung check #596

merged 1 commit into from
Aug 12, 2021

Conversation

lizhuqi
Copy link
Contributor

@lizhuqi lizhuqi commented Jul 23, 2021

Remove aufs related checks.

Dcoker now perfers overlay2 to aufs for its current versions and it no longer depends on aufs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @lizhuqi!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lizhuqi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2021
@Random-Liu
Copy link
Member

/ok-to-test

It should be OK to remove AUFS from the default config.

/lgtm
/apprve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2021
@Random-Liu
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2021
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jul 26, 2021

/retest

5 similar comments
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jul 27, 2021

/retest

@Random-Liu
Copy link
Member

/retest

@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jul 29, 2021

/retest

@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jul 29, 2021

/retest

@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jul 30, 2021

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2021
@lizhuqi lizhuqi mentioned this pull request Jul 31, 2021
Merged
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Aug 11, 2021

/retest

1 similar comment
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Aug 11, 2021

/retest

@lizhuqi
Copy link
Contributor Author

lizhuqi commented Aug 11, 2021

last run was still testing against old test code. My change in kubernetes/kubernetes#104048 was not applied.

Rerun the test.

/retest

@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizhuqi, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f1aa82a into kubernetes:master Aug 12, 2021
@lizhuqi lizhuqi mentioned this pull request Dec 14, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizhuqi @k8s-ci-robot @Random-Liu