Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag releases via PR #819

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Tag releases via PR #819

merged 2 commits into from
Jan 3, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 21, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2023
@MartinForReal
Copy link
Contributor

I'm a little bit confused. Maybe It is easier if we push new tag to github?

@hakman
Copy link
Member Author

hakman commented Sep 21, 2023

I'm a little bit confused. Maybe It is easier if we push new tag to github?

That is dependent on someone having admin permissions on the repo.
Doing it via PR is possible for any contributor to propose a new release. After merge, one more PR in the k8s.io repo and that should be it.
In any case, it's a proposal.

xiaods
xiaods reviewed Sep 25, 2023
View reviewed changes
.github/workflows/tag-release.yml Outdated

jobs:
tag:
if: ${{ github.repository == 'kubernetes/cloud-provider-aws' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cloud-provider-aws?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, fixed. thanks!

xiaods
xiaods reviewed Sep 25, 2023
View reviewed changes
hack/tag-release.sh Outdated
fi

git tag -a -m "Release ${VERSION}" "v${VERSION}"
git push origin "v${VERSION}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest add v to version.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

version.txt Outdated
@@ -0,0 +1 @@
0.8.15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest add v to version.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hakman
Copy link
Member Author

hakman commented Oct 4, 2023

@vteratipally @mmiranda96 Any thoughts about this PR?

@vteratipally
Copy link
Collaborator

/cc @Random-Liu

@hakman hakman mentioned this pull request Oct 5, 2023
Closed
@hakman
Copy link
Member Author

hakman commented Jan 2, 2024

@vteratipally @Random-Liu Could you take one more look at this? Would help with releases going forward.

@disconn3ct
Copy link

Does the k8s org have a code of conduct for maintainers? What is the process for handling abdicated repositories?

@vteratipally
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3704fa7 into kubernetes:master Jan 3, 2024
5 checks passed
@hakman hakman deleted the tag-releases branch January 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaods xiaods xiaods left review comments

@vteratipally vteratipally Awaiting requested review from vteratipally

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@vteratipally vteratipally

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hakman @MartinForReal @vteratipally @disconn3ct @k8s-ci-robot @xiaods