-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CBL-Mariner and Azure Linux #890
Add support for CBL-Mariner and Azure Linux #890
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @hbeberman! |
Hi @hbeberman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@hbeberman Please sign the CLA, to be able to review & merge this. Thanks! |
/ok-to-test |
The change looks ok to me. Today we do not have any OSS E2E test coverage for those os types. Do you want to add them? This is not a requirement for this PR. But I think it may be beneficial to you. |
/check-cla |
@hakman sorry for the delay! I was making sure everything was squared away to sign the CLA from my side, but I've now signed it. @wangzhen127 great suggestion on the E2Es. I'm looking into the implementation details and will follow up with a separate contribution if it's something we can add for Mariner / Azure Linux. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, hbeberman, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds support for
mariner
andazurelinux
in the getOSVersion helper function.Azure Linux (aka CBL-Mariner) is a Linux distribution maintained by Microsoft which is currently available in Azure Kubernetes Service and is also used in other parts of the cloud infrastructure and edge products.
For a few years we've been using a patched version of node-problem-detector which adds Mariner into this switch case. I'm looking to get "mariner" and the upcoming os-release name of "azurelinux" added into node-problem-detector directly so that we can drop the patch and be compatible with instances of the binary built outside of our distro.