Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #912

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

sozercan
Copy link
Contributor

@sozercan sozercan commented May 17, 2024

Hey folks,

This is originally generated by https://app.stepsecurity.io/securerepo and I updated with a few changes
sozercan#1

What this PR does:

  • Adds dependabot with a weekly cadence with grouping for GHA and k8s deps to bump various dependencies like gomod, docker etc, to make lives of maintainers easier
  • introduces codeql, openssf scorecard and dependency review to improve supply chain security
  • pins existing GHA to improve security. these dependencies will still automatically get bumped by dependabot
  • adds harden runner with an audit policy. this will surface network endpoints used by the CI. and in the future, you can change this to deny to enable network isolation for improved security
  • sets least amount of permissions to existing workflows
  • adds optional pre-commit hooks to shift left to prevent any cred leaks, linting, etc
  • pins golang builder image to a digest. this will still automatically get bumped by dependabot
  • remove baseimage docker var, since the image won't be able to get bumped automatically with that

step-security-bot and others added 2 commits May 17, 2024 18:41
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @sozercan!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @sozercan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2024
@hakman
Copy link
Member

hakman commented May 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2024
@hakman
Copy link
Member

hakman commented Aug 30, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2024
@hakman
Copy link
Member

hakman commented Aug 30, 2024

@sozercan This looks amazing. Should make maintaining this repo much easier.
@wangzhen127 Could you please take a look?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2024
@wangzhen127
Copy link
Member

wangzhen127 commented Sep 13, 2024

Thanks for setting this up! There were several recent changes on .github/workflows/update-deps.yml. @jingxu97 Can you take a look to see if this satisfy your needs? Or if any followup change is needed?

@hakman
Copy link
Member

hakman commented Sep 17, 2024

Ping @wangzhen127 @jingxu97

# "build-context": https://github.com/docker/buildx/pull/904#issuecomment-1005871838
FROM golang:1.22.3-bookworm as builder-base
FROM golang:1.22-bookworm@sha256:5c56bd47228dd572d8a82971cf1f946cd8bb1862a8ec6dc9f3d387cc94136976 as builder-base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not also put patch version there?

@jingxu97
Copy link
Contributor

sorry for the delay, I think this is good for our use case.

@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, sozercan, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 200d467 into kubernetes:master Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants