Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FOSSA license scanning across all Kubernetes orgs #164

Closed
justaugustus opened this issue Oct 12, 2018 · 11 comments
Closed

Enable FOSSA license scanning across all Kubernetes orgs #164

justaugustus opened this issue Oct 12, 2018 · 11 comments
Assignees
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps

Comments

@justaugustus
Copy link
Member

justaugustus commented Oct 12, 2018

Organization or repository

All k8s orgs

Name of integration

FOSSA

Link to integration website

Describe what is attempting to be accomplished

As a project, we'd like to be able to scan software licenses with some framework and it seems the general consensus has been to use FOSSA.
There are multiple tracking issues and threads to catch up on, so I'll point there instead:

Additional context for request

N/A

/area github-integration
/assign
/cc @kubernetes/owners @nikhita @dims @swinslow

@k8s-ci-robot k8s-ci-robot added the area/github-integration Third-party integrations, webhooks, or GitHub Apps label Oct 12, 2018
@dims
Copy link
Member

dims commented Oct 12, 2018

@justaugustus can you please point us to the page that describes the permissions needed by this app?

@justaugustus
Copy link
Member Author

@dims -- here you go: https://github.com/fossas/fossa-docs/blob/master/src/md/getting-started/repository-permissions.md

added to the issue description as well.

@spiffxp
Copy link
Member

spiffxp commented Oct 12, 2018

Write access to repo webhooks makes me a little leery
screen shot 2018-10-12 at 2 22 38 pm

@spiffxp
Copy link
Member

spiffxp commented Oct 12, 2018

I see this already happens to be enabled for google and GoogleCloudPlatform, so I figure if it's good enough for them...

But seriously, discussed in private with the rest of @kubernetes/owners, it's been enabled for kubernetes-sigs for a bit and nothing has caught on fire, so we're ok with this

@fejta
Copy link
Contributor

fejta commented Oct 12, 2018

This is fine as a first step. +1

At what kind of cadence does this provide results? Ideally we find a solution that allows us to prevent merges of bad licenses, in addition to flagging problems after the fact.

@spiffxp
Copy link
Member

spiffxp commented Oct 12, 2018

I clicked the 'grant' button for the kubernetes orgs I manage. Explicitly not touching kubernetes-security.

screen shot 2018-10-12 at 3 00 14 pm

@idvoretskyi
Copy link
Member

@justaugustus +1. Thanks for doing this!

@cblecker
Copy link
Member

+1 in support of this.

@spiffxp
Copy link
Member

spiffxp commented Oct 12, 2018

/close
I leave it to @justaugustus to continue setting this up, please ping here / reopen if permissions still aren't correct for you to do what you need

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
I leave it to @justaugustus to continue setting this up, please ping here / reopen if permissions still aren't correct for you to do what you need

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

Yayyyyy! I'll be kicking off documentation around the Licensing / Compliance subproject next week. It was mentioned here originally, but I've actually got bandwidth to do stuff now.

Thanks @spiffxp! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps
Projects
None yet
Development

No branches or pull requests

7 participants