Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New (staging) repo for k8s network information distributor / aka kube-proxy2 #2410

Closed
mcluseau opened this issue Jan 11, 2021 · 20 comments
Closed
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Milestone

Comments

@mcluseau
Copy link

mcluseau commented Jan 11, 2021

New Repo, Staging Repo, or migrate existing

new repository (can migrate from https://github.com/mcluseau/kube-proxy2)

Requested name for new repository

Edit (nikhita): final name is kpng. See discussion below.

TBD: the name is not yet decided. Proposals:

  • knid (k8s network information distribution)
  • ksdn
  • kube-proxy-ng
  • ...

Which Organization should it reside

kubernetes-sigs / sig-network

If not a staging repo, who should have admin access

staging repo

If not a staging repo, who should have write access

staging repo

If not a staging repo, who should be listed as approvers in OWNERS

staging repo

If not a staging repo, who should be listed in SECURITY_CONTACTS

staging repo

What should the repo description be

depends on the chosen name

What SIG and subproject does this fall under in sigs.yaml

this is a new subproject for sig-network called [TBD: chosen name]

Approvals

Creation advised by @thockin

@mcluseau mcluseau added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Jan 11, 2021
@nikhita
Copy link
Member

nikhita commented Jan 13, 2021

@mcluseau since this would be a staging repo, this will also need approval from sig-architecture.

Creation advised by @thockin

/assign @thockin
to ack on approval for the record

@mcluseau
Copy link
Author

@nikhita thanks for your answer, on the "staging" part, it's what looked like my idea, but it's incubating, ie publishing the code in the k8s realm so others can contribute, until we reach the next stage.

@thockin
Copy link
Member

thockin commented Jan 16, 2021

A staging repo, as fart as I understand, exists in k/k/staging/src/k8s.io/... - I do not think that's what we want here.

As for names, I am terrible at naming things but I can filter some out :)

"knid" is too close to "kind"
"ksdn" carries SDN connotation that I don't think we want.
"kube-proxy-ng" is a little long, but clear. I don't like "kube-proxy" as a name because it's really not a proxy.

Throwing some suggestions:

epsel - the endpoints selector
kp2
kpng - pronounced "kaping"
kpow - kupe-proxy object watcher
seppi - service/endpoint preprocessing interface

brainstorm!

@justaugustus
Copy link
Member

(Drive-by comment to say I like kpng and kpow. 🙃)

@mcluseau
Copy link
Author

kest - kubernetes endpoints & services transport (pronounced "quest")
knest - k8s network endpoitns & services transport (fun too, matures the eggs to produce the final flying thing)

@mcluseau
Copy link
Author

mcluseau commented Jan 16, 2021

ksept - works too (service endpoints transport), where sept is seven in french, and the number of edges in the k8s logo

@mcluseau
Copy link
Author

seems like kpng is the winner here so let's go for it ;-)

@thockin
Copy link
Member

thockin commented Jan 25, 2021

I can live with kpng - it's not like we can't change it as we evolve it.

@dims
Copy link
Member

dims commented Jan 25, 2021

+1 to kpng

@nikhita
Copy link
Member

nikhita commented Jan 27, 2021

@mcluseau
Copy link
Author

@nikhita ok wilco and notify here when done, thanks :)

@mcluseau
Copy link
Author

ok, I think I've gone through the checklist

@nikhita
Copy link
Member

nikhita commented Jan 29, 2021

@mcluseau Can you also update the template files to match the repo? For instance, these files would need update - README.md, OWNERS, OWNERS_ALIASES (this can be deleted if not needed), and SECURITY_CONTACTS.

@mcluseau
Copy link
Author

mcluseau commented Jan 29, 2021

ohhh... ok... I'm responsible of those too now, that's something real 😱 ;-)
(updated to a basic version of those files)

@nikhita
Copy link
Member

nikhita commented Feb 2, 2021

@mcluseau if you are in the OWNERS file, you also need to be a member of the @kubernetes-sigs GitHub organization to be able to approve PRs.

Can you create an issue to request membership? Detailed instructions are here - https://github.com/kubernetes/community/blob/master/community-membership.md#member

@spiffxp
Copy link
Member

spiffxp commented Mar 10, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@nikhita
Copy link
Member

nikhita commented Mar 24, 2021

@mcluseau I think we're good to go ahead with the migration!

Can you move https://github.com/mcluseau/kube-proxy2 to https://github.com/kubernetes-purgatory? (you should have an invite)

I'll need admin access to the repo to be able to migrate it to k-sigs, but GitHub doesn't allow adding admins to user-owned repos so we'll need to migrate it to a dummy org first.

@mcluseau
Copy link
Author

Hi @nikhita , yes the time has come :) I pushed under the voted name (kpng): https://github.com/kubernetes-purgatory/kpng

@nikhita
Copy link
Member

nikhita commented Mar 25, 2021

Repo has been migrated - https://github.com/kubernetes-sigs/kpng

Also created:

Once both PRs merge, this issue can be closed.

@nikhita nikhita self-assigned this Mar 25, 2021
@nikhita
Copy link
Member

nikhita commented Mar 26, 2021

All PRs have merged and teams have been granted access. Closing.

@nikhita nikhita closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

No branches or pull requests

7 participants