Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Members 08-20-2021 #2913

Merged
merged 9 commits into from
Aug 23, 2021
Merged

Add Members 08-20-2021 #2913

merged 9 commits into from
Aug 23, 2021

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Aug 20, 2021 •
edited
Loading

Fixes #2896
Fixes #2900
Fixes #2901
Fixes #2903
Fixes #2904
Fixes #2905
Fixes #2907
Fixes #2908
Fixes #2909

/cc @ameukam @palnabarun
/hold for reviews

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 20, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2021
This was referenced Aug 20, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Xunzhuo
Copy link
Member

Xunzhuo commented Aug 20, 2021 •
edited
Loading

Hi @savitharaghunathan , I think my request is missing , please take a look ~ #2900

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
@palnabarun
Copy link
Member

/lgtm
/approve

Thank you @savitharaghunathan 🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@savitharaghunathan
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit ab50bae into kubernetes:main Aug 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
4 participants
@savitharaghunathan @Xunzhuo @palnabarun @k8s-ci-robot