Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peribolos: update GH teams perms across org files #4363

Merged
merged 11 commits into from
Aug 1, 2023
Merged

Peribolos: update GH teams perms across org files #4363

merged 11 commits into from
Aug 1, 2023

Conversation

Priyankasaggu11929
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 commented Aug 1, 2023 •
edited

The PR

  • updates the following team repo permissions, to add members/bot accounts removed by Peribolos
    (ref: https://kubernetes.slack.com/archives/CHGFYJVAN/p1690906660582369)
    - sig-contributor-experience
    - stage-bot
    - release-team
    - sig-release
    - sig-testing
    - sig-k8s-infra
    - production-readiness
    - sig-cloud-provider

  • update admin/update.sh script to include --skip-removals flag

/sig contributor-experience
/assign @MadhavJivrajani
/hold

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2023
palnabarun
palnabarun reviewed Aug 1, 2023
View reviewed changes
config/kubernetes-sigs/sig-cluster-lifecycle/teams.yaml Outdated
Comment on lines 346 to 368
# members added in commented lines have a pending membership
# and will be added back once it is acquired.
# - adilGhaffarDev
- aniruddha2000
- cahillsf
- cecilerobertmichon
- chiukapoor
- chrischdi
- furkatgofurov7
- g-gaston
- hackeramitkumar
- joekr
- johannesfrey
- killianmuldoon
# - kranurag7
# - mjlshen
- nawazkh
- nprokopic
- Prajyot-Parab
# - razashahid107
- sbueringer
# - Sunnatillo
- tobiasgiese
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a legit removal. Ref: #4353

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop these changes since they are supposed to be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Changes to the whole file can be dropped. GitHub UI is weird and doesn't show the whole selection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped the respective commit. Thanks!

@Priyankasaggu11929
Copy link
Member Author

/hold

will fix the failing CI tests once done adding back all usernames.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2023
palnabarun
palnabarun reviewed Aug 1, 2023
View reviewed changes
config/kubernetes-sigs/sig-cluster-lifecycle/teams.yaml
- srm09
- vincepri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can also be dropped. Ref: #4345

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Changes to the whole file can be dropped. GitHub UI is weird and doesn't show the whole selection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped it as part of the respective entire commit. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just realised. I missed this. Will raise a PR to fix this tomorrow,

@palnabarun
Copy link
Member

Keeping a living copy of the changes that can be dropped:

MadhavJivrajani
MadhavJivrajani requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping a note as a requested change to prevent accident merge: we need to include --skip-removals flag in admin/update.sh.

@MadhavJivrajani MadhavJivrajani mentioned this pull request Aug 1, 2023
Merged
@Priyankasaggu11929
Copy link
Member Author

@MadhavJivrajani, include the --skip-removals in the admin/update.sh.

From my side, the changes to add back members are done.

MadhavJivrajani
MadhavJivrajani approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MadhavJivrajani, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7f32370 into kubernetes:main Aug 1, 2023
4 checks passed
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Aug 2, 2023
Merged
@MadhavJivrajani MadhavJivrajani mentioned this pull request Aug 2, 2023
Closed
9 tasks
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun left review comments

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@bridgetkromhout bridgetkromhout Awaiting requested review from bridgetkromhout

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Priyankasaggu11929 @palnabarun @k8s-ci-robot @CecileRobertMichon @MadhavJivrajani