-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peribolos: update GH teams perms across org files #4363
Peribolos: update GH teams perms across org files #4363
Conversation
# members added in commented lines have a pending membership | ||
# and will be added back once it is acquired. | ||
# - adilGhaffarDev | ||
- aniruddha2000 | ||
- cahillsf | ||
- cecilerobertmichon | ||
- chiukapoor | ||
- chrischdi | ||
- furkatgofurov7 | ||
- g-gaston | ||
- hackeramitkumar | ||
- joekr | ||
- johannesfrey | ||
- killianmuldoon | ||
# - kranurag7 | ||
# - mjlshen | ||
- nawazkh | ||
- nprokopic | ||
- Prajyot-Parab | ||
# - razashahid107 | ||
- sbueringer | ||
# - Sunnatillo | ||
- tobiasgiese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a legit removal. Ref: #4353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop these changes since they are supposed to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Changes to the whole file can be dropped. GitHub UI is weird and doesn't show the whole selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped the respective commit. Thanks!
/hold will fix the failing CI tests once done adding back all usernames. |
- srm09 | ||
- vincepri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can also be dropped. Ref: #4345
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Changes to the whole file can be dropped. GitHub UI is weird and doesn't show the whole selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped it as part of the respective entire commit. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, just realised. I missed this. Will raise a PR to fix this tomorrow,
Keeping a living copy of the changes that can be dropped:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping a note as a requested change to prevent accident merge: we need to include --skip-removals
flag in admin/update.sh
.
4e7ae33
to
3b58205
Compare
@MadhavJivrajani, include the --skip-removals in the From my side, the changes to add back members are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The PR
updates the following team repo permissions, to add members/bot accounts removed by Peribolos
(ref: https://kubernetes.slack.com/archives/CHGFYJVAN/p1690906660582369)
-
sig-contributor-experience
-
stage-bot
-
release-team
-
sig-release
-
sig-testing
-
sig-k8s-infra
-
production-readiness
-
sig-cloud-provider
update
admin/update.sh
script to include--skip-removals
flag/sig contributor-experience
/assign @MadhavJivrajani
/hold