Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd-io org #4498

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Add etcd-io org #4498

merged 1 commit into from
Jan 27, 2024

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Oct 2, 2023

This adds the etcd-io org under administration

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Oct 2, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2023
@cblecker
Copy link
Member Author

cblecker commented Oct 2, 2023

/hold
the github bot needs to join the org first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2023
@ahrtr
Copy link
Member

ahrtr commented Oct 6, 2023

Could you please update https://github.com/kubernetes/org/blob/main/OWNERS_ALIASES as well? thx

config/etcd-io/org.yaml Outdated Show resolved Hide resolved
@wenjiaswe
Copy link

@cblecker Just a friendly ping. Really appreciate your help working on this, or please let us know if it's easier for us to work on this. Thanks!

@cblecker
Copy link
Member Author

@wenjiaswe Sorry for the delay on this. We're actually working through some technical difficulties getting the bot added to the org, which is what is holding this up. We're in contact with GitHub and will let you know once we figure out a path forward. Thanks for your patience!

@wenjiaswe
Copy link

Sure, thank you very much, just want to make sure there is nothing pending on us.

@cblecker
Copy link
Member Author

@wenjiaswe An update: we are still working on this. We made another pre-requisite change today, moving this org out of the CNCF enterprise account into the Kubernetes one. Still working with GH on some of the other pieces.

config/etcd-io/org.yaml Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Nov 17, 2023

Not sure if we should mark this as SIG etcd?

@wenjiaswe
Copy link

Not sure if we should mark this as SIG etcd?

@sftim sure, that's a good idea just to make sure it's under SIG-etcd's radar.

I just want to make sure, marking this as SIG-etcd won't take this off the attention list of github admins.

@wenjiaswe
Copy link

Wenjia An update: we are still working on this. We made another pre-requisite change today, moving this org out of the CNCF enterprise account into the Kubernetes one. Still working with GH on some of the other pieces.

@cblecker Thank you for the update, and thank you very much for helping us to set this up!

@jmhbnz
Copy link
Member

jmhbnz commented Jan 9, 2024

Hey @cblecker - Can you please provide an update on the next step for this pr? Thanks! 🙏🏻

cc @wenjiaswe

@cblecker
Copy link
Member Author

cblecker commented Jan 10, 2024

@jmhbnz @wenjiaswe Sorry for the delay on this one. Onboarding a new org isn't something we do frequently, and it's exposed some issues with the process. We're still waiting to hear back from our contacts at GH on a blocking issue (I can't get into specifics publicly as there are some security implications), but we haven't forgot about this one at all. Very much hope to have this resolved soon as folks are getting back from the winter break. Really appreciate your patience!

@cblecker
Copy link
Member Author

@jmhbnz @wenjiaswe I have good news! The issues that were preventing this change from moving forward have been resolved!

I've taken a fresh dump of the current state, and this is ready for review. :)

@cblecker cblecker requested review from jmhbnz, serathius and wenjiaswe and removed request for palnabarun and MadhavJivrajani January 27, 2024 01:12
@cblecker cblecker added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Jan 27, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Many thanks for your help on this @cblecker 🙏🏻

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member Author

/hold cancel

Let's go!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit ffaa720 into kubernetes:main Jan 27, 2024
4 checks passed
@cblecker cblecker deleted the etcd branch January 27, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants