Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to inject additional measurements to load config #2483

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Argh4k
Copy link
Contributor

@Argh4k Argh4k commented Dec 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR allows to inject additional measurements via CL2_ADDITIONAL_MEASURMENT_MODULES to load/config.yaml.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2023
@Argh4k
Copy link
Contributor Author

Argh4k commented Dec 20, 2023

/assign @mborsz

@Argh4k
Copy link
Contributor Author

Argh4k commented Dec 21, 2023

/retest

@Argh4k
Copy link
Contributor Author

Argh4k commented Dec 21, 2023

It looks like tests failures are unrelated to my change as clusterloader is not able to ssh on to the master:

error getting SSH client to prow@34.23.203.237:22: 'ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

@mborsz
Copy link
Member

mborsz commented Jan 8, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Argh4k, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 8, 2024

Tests are failing with:

ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - Quota 'N2_CPUS' exceeded.  Limit: 24.0 in region us-east1.
	metric name = compute.googleapis.com/n2_cpus
	limit name = N2-CPUS-per-project-region
	limit = 24.0
	dimensions = region: us-east1

@mborsz
Copy link
Member

mborsz commented Jan 8, 2024

Why do we use N2 in our tests? it seems to be quite new

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 8, 2024

kubernetes/test-infra#31546

I will raise this in sig-testing slack channel.

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 8, 2024

/retest

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 8, 2024

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 9, 2024

/retest

@dlapcevic
Copy link
Contributor

Thanks @Argh4k for looking into the test failures.
I have the same cl2 test failures in my PR #2494.

I see that the quota increase for N2 machines is in progress.
Is it tracked somewhere?

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 10, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@Argh4k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-perf-tests-clusterloader2 5a36f2c link true /test pull-perf-tests-clusterloader2
pull-perf-tests-clusterloader2-kubemark 5a36f2c link true /test pull-perf-tests-clusterloader2-kubemark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 10, 2024

@dlapcevic unfortunately all the information that I have are from the slack thread that I posted here :(

@Argh4k
Copy link
Contributor Author

Argh4k commented Jan 11, 2024

@mborsz can we push it through? Clusterloader2 test is failing with N2 quota issue and clusterloader2-kubemark is failing with:

ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - Setting minimum CPU platform is not supported for the selected machine type e2-standard-8.

They do not seem to be connected to my CL.

For testing I've set up a simple test with measurments in file one directory above and run the clusterloader with that. I'm attaching files and generatedConfig for that (they are formatted as txt but in reality those are yamls as github does not allow to attach yamls in the comment)

generatedConfig_test.txt
measurements.txt
config.txt

@mborsz mborsz merged commit a5ac4af into kubernetes:master Jan 11, 2024
4 of 7 checks passed
@marseel
Copy link
Member

marseel commented Jan 12, 2024

FYI kubernetes/k8s.io#6271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants